Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD-1467 DD-1493 cleanup of batch processors #55

Merged
merged 11 commits into from
Mar 7, 2024

Conversation

jo-pol
Copy link
Contributor

@jo-pol jo-pol commented Feb 22, 2024

Fixes DD-1467 DD-1493 follow up: cleanup of batch processors

Description of changes

  • moved searching for all dataset pids out of get_entries, consider util wrappers around both when needed again
  • reworded logging to something neutral
  • dropped the batch processors introduced by DD-1493

How to test

See #51 and #53
as well as poetry run dv-dataset-get-attributes

Related PRs

(Add links)

Notify

@DANS-KNAW/core-systems

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.80%. Comparing base (874b360) to head (dff4114).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   47.48%   48.80%   +1.32%     
==========================================
  Files          19       19              
  Lines         954      963       +9     
==========================================
+ Hits          453      470      +17     
+ Misses        501      493       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

janvanmansum
janvanmansum previously approved these changes Feb 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.80%. Comparing base (874b360) to head (6db8ba2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   47.48%   48.80%   +1.32%     
==========================================
  Files          19       19              
  Lines         954      963       +9     
==========================================
+ Hits          453      470      +17     
+ Misses        501      493       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@PaulBoon PaulBoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jo-pol jo-pol merged commit 823b98e into DANS-KNAW:master Mar 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants