-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DD-1467 DD-1493 cleanup of batch processors #55
DD-1467 DD-1493 cleanup of batch processors #55
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 47.48% 48.80% +1.32%
==========================================
Files 19 19
Lines 954 963 +9
==========================================
+ Hits 453 470 +17
+ Misses 501 493 -8 ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 47.48% 48.80% +1.32%
==========================================
Files 19 19
Lines 954 963 +9
==========================================
+ Hits 453 470 +17
+ Misses 501 493 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Fixes DD-1467 DD-1493 follow up: cleanup of batch processors
Description of changes
How to test
See #51 and #53
as well as
poetry run dv-dataset-get-attributes
Related PRs
(Add links)
Notify
@DANS-KNAW/core-systems