Patch to correctly find DLL and dependencies #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch to correctly find DLL and dependencies in PATH variable on Windows. Works, but the except: pass bit is a bit janky - for some reason, it throws an error after adding all the paths otherwise.
|
I don't love the try-catch logic where we're pulling something manually from the PATH environment variable. Is there no better way to solve this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to correctly find DLL and dependencies in PATH variable on Windows.
Works, but the except: pass bit is a bit janky - for some reason, it throws an error after adding all the paths otherwise.
Fixes #10