Mark as nullable arguments with initial null value #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
LGTM, leaving it up to @DEVizzent to decide if this is a breaking change for the interfaces and needs a new major or not. Thanks for putting this together 👍
|
The changes in interfaces are not breaking changes. Anyone who's implementing them in userland code and does not explicitly define the nullable type, can safely update to this and won't get any error. |
Fair, forgot about that one 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some deprecation warnings thrown with PHP 8.4 due to implicit nullability in some method arguments.
The solution involves explicitly marking them as nullable with
?string $foo = nullinstead ofstring $foo = null.See the RFC for details https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
Additionally, I also added PHP 8.4 to the php workflow, to verify deprecation warnings are not printed.