Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[155] Add govuk markdown and cookies page #103

Merged
merged 4 commits into from
Aug 24, 2023
Merged

[155] Add govuk markdown and cookies page #103

merged 4 commits into from
Aug 24, 2023

Conversation

AbigailMcP
Copy link
Contributor

Changes proposed in this pull request

  • Add govuk-markdown gem
  • Add cookies markdown page and link to from footer
  • Add new two_thirds layout and static controller for static pages

Guidance to review

  • Click link on footer, check the cookies page
Screenshot 2023-08-22 at 15 24 52

Link to Trello card

https://trello.com/c/wMknFvgs/155-create-static-pages-cookies

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@AbigailMcP AbigailMcP added the deploy Deploys a review app label Aug 22, 2023
@github-actions github-actions bot temporarily deployed to review-103 August 22, 2023 14:29 Destroyed
@github-actions github-actions bot temporarily deployed to review-103 August 22, 2023 14:42 Destroyed
@AbigailMcP
Copy link
Contributor Author

Create static pages (cookies)

@github-actions github-actions bot temporarily deployed to review-103 August 22, 2023 14:55 Destroyed
@steventux
Copy link
Contributor

steventux commented Aug 23, 2023 •
edited
Loading

@AbigailMcP tests are failing because of a mismatch between RAILS_MASTER_KEY in Github secrets and config/credentials.ymc.enc. We don't actually use the latter and its safe to delete, or we can ask @gpeng to remove the secrets on GH as they were for testing db encryption.

@github-actions github-actions bot temporarily deployed to review-103 August 23, 2023 08:59 Destroyed
@github-actions github-actions bot temporarily deployed to review-103 August 24, 2023 09:10 Destroyed
@AbigailMcP AbigailMcP merged commit dbff77c into main Aug 24, 2023
10 checks passed
@AbigailMcP AbigailMcP deleted the 246-static-pages branch August 24, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steventux steventux steventux approved these changes

Assignees
No one assigned
Labels
deploy Deploys a review app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbigailMcP @steventux