Add organisation and profile to scope array #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fields will be returned by DSI after successful authentication.
AbigailMcP
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to restrict access to the service so that only DfE staff and agencies have access. The plan is to do this by checking against a list we manage in the service, using data sent by DSI.
Changes proposed in this pull request
Adding organisation to the scope array will return data related to the organisation claim in the response from DSI after successful authentication. Specifically, in "extra"."raw_info"."organisation". The "companyRegistrationNumber" in there is what we'll use to check a hardcoded list of agencies.
Guidance to review
Link to Trello card
Checklist