Add BQ table check job #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
force-pushed
the
1820-add-bigquery-table-check
branch
from
995d4ad to
8612924
Compare
gpeng
suggested changes
Feb 16, 2024
config/clock.rb
Outdated
| @@ -3,4 +3,5 @@ | |||
|
|
|||
| module Clockwork | |||
| every(1.day, "DeleteUnconfirmedEntries.perform_later", at: "00:00") | |||
| every(30.minutes, "DfE::Analytics::EntityTableCheckJob.set(queue: 'analytics').perform_later") | |||
There was a problem hiding this comment.
The data insights team are suggesting once a day. I don't think we need to send it this often.
To be run on analytics queue every day at 00:30.
steventux
force-pushed
the
1820-add-bigquery-table-check
branch
from
8612924 to
25e8746
Compare
gpeng
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The data insights team have asked if we can add a check to our services to verify the data that we’re holding in BigQuery. The check periodically sends table row counts that can be checked against the big query data and runs as a scheduled job.
Changes proposed in this pull request
Add dfe-analytics config and schedule appropriate job to check tables.
Guidance to review
Link to Trello card
https://trello.com/c/fVu2pkoU/1820-add-bigquery-table-check
Checklist