[2146] Replace terrafile #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app https://technical-guidance-204.test.teacherservices.cloud was deleted |
saliceti
force-pushed
the
2146-spike-replace-terrafile
branch
from
4a0d3ff
to
44b2803
Compare
terrafile is not maintained anymore. Replacing with simple git command
saliceti
force-pushed
the
2146-spike-replace-terrafile
branch
from
44b2803
to
b11fcfa
Compare
The previous version was causing error: Error: "conditions.0.url_path_condition.0.match_values.0" must not begin with the URLs leading slash(e.g. /), got "/.well-known/security.txt"
neillturner
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
terrafile is not maintained anymore. Replacing with simple git command
Also update azurerm provider to 3.116.0 to avoid error with domains
How to review
run
make review terraform-plan PR_NUMBER=1234
make production terraform-plan CONFIRM_PRODUCTION=yes
make domains-infra-plan
make production domains-plan CONFIRM_PRODUCTION=yes