Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add "show" to pref-adjust #1375

Merged

Conversation

TolMera
Copy link
Contributor

@TolMera TolMera commented Jan 18, 2025

This feature returns the list of Likes for a selected dwarf.

This script may be useful if:

  • a user wants to view a quick list of likes for a dwarf
  • a user wants to view the list of likes after updating a dwarfs likes
  • Other scripts may find this helpful, as this functionality is not otherwise exposed via dfhack

This feature returns the list of Likes for a selected dwarf.

This script may be useful if:
* a user wants to view a quick list of likes for a dwarf
* a user wants to view the list of likes after updating a dwarfs likes
* Other scripts may find this helpful, as this functionality is not otherwise exposed via dfhack
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add a line to the Misc Improvements section of the "Future" version in changelog.txt

Thanks!

pref-adjust.lua Outdated Show resolved Hide resolved
pref-adjust.lua Outdated Show resolved Hide resolved
pref-adjust.lua Outdated Show resolved Hide resolved
pref-adjust.lua Outdated Show resolved Hide resolved
pref-adjust.lua Outdated Show resolved Hide resolved
pref-adjust.lua Outdated Show resolved Hide resolved
pref-adjust.lua Outdated Show resolved Hide resolved
pref-adjust.lua Outdated Show resolved Hide resolved
TolMera and others added 6 commits January 19, 2025 18:50
otherwise you'll get an extra error printed to the console when no unit is selected

Co-authored-by: Myk <[email protected]>
Functional update: updated script to use call to `dfhack.script_help` function
Added notes to future>misc as requested in PR
Feedback on this is that if a unit is not selected, and this function is called, you will get two errors printed instead of the expected one.
@TolMera
Copy link
Contributor Author

TolMera commented Jan 19, 2025

pre-commit.ci autofix

changelog.txt Outdated Show resolved Hide resolved
docs/pref-adjust.rst Outdated Show resolved Hide resolved
docs/pref-adjust.rst Outdated Show resolved Hide resolved
docs/pref-adjust.rst Outdated Show resolved Hide resolved
docs/pref-adjust.rst Outdated Show resolved Hide resolved
docs/pref-adjust.rst Outdated Show resolved Hide resolved
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! we're in code freeze for the release tomorrow, but I'll merge it soon after we tag

@myk002 myk002 merged commit d4a10bd into DFHack:master Jan 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants