-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation with Visual Studio (15.9.5) #1380
Merged
Merged
Commits on Jan 14, 2019
-
With Visual Studio Community 2017 (15.9.5), namespace 'experimental' is present both in 'std' and 'DGtal' namespaces and it produces an error. Using 'std' namespace explicitly solves the problem.
Configuration menu - View commit details
-
Copy full SHA for 0b6ee14 - Browse repository at this point
Copy the full SHA 0b6ee14View commit details -
On Windows 10, with Visual Studio Community 2017 (15.9.5), the file wingdi.h is included. This file alredy defines 'Arc' as a function. Thus Visual produces an error if 'Arc' is declared to define a type. Changing the typedef from 'Arc' to 'ArcT' solves the problem.
Configuration menu - View commit details
-
Copy full SHA for 0f027a5 - Browse repository at this point
Copy the full SHA 0f027a5View commit details
Commits on Jan 15, 2019
-
When compiling with Visual Studio (tested with 15.9.5), several io tests (testLongVol, testPNMReader, testVolReader, testCompressedVolWriter) fail if binary mode is not correctly set for iostreams. This commit makes these tests pass.
Configuration menu - View commit details
-
Copy full SHA for b792378 - Browse repository at this point
Copy the full SHA b792378View commit details -
Read only two characters for PGM header
On Windows (with Visual Studio), the call to getline() may be found '\r' before '\n'. By restricting the header check to only two characters, we avoid this problem. This change makes testGenericReader and testGenericWriter pass.
Configuration menu - View commit details
-
Copy full SHA for 52ac7ca - Browse repository at this point
Copy the full SHA 52ac7caView commit details -
Explicit functors construction for Composer
Build functors passed to Composer functor explicitly. This change makes testPNMRawWriter pass (with Visual Studio).
Configuration menu - View commit details
-
Copy full SHA for 97f4fd7 - Browse repository at this point
Copy the full SHA 97f4fd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1209a28 - Browse repository at this point
Copy the full SHA 1209a28View commit details
Commits on Jan 22, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2be8f9e - Browse repository at this point
Copy the full SHA 2be8f9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21012d9 - Browse repository at this point
Copy the full SHA 21012d9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.