Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation with Visual Studio (15.9.5) #1380

Merged
merged 8 commits into from
Jan 26, 2019

Commits on Jan 14, 2019

  1. Use std namespace explicitly.

    With Visual Studio Community 2017 (15.9.5), namespace 'experimental' is present both in 'std' and 'DGtal' namespaces and it produces an error.
    Using 'std' namespace explicitly solves the problem.
    BorisMansencal committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    0b6ee14 View commit details
    Browse the repository at this point in the history
  2. Rename type ArcT

    On Windows 10, with Visual Studio Community 2017 (15.9.5), the file wingdi.h is included. This file alredy defines 'Arc' as a function. Thus Visual produces an error if 'Arc' is declared to define a type. Changing the typedef from 'Arc' to 'ArcT' solves the problem.
    BorisMansencal committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    0f027a5 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2019

  1. Open iostreams in binary mode

    When compiling with Visual Studio (tested with 15.9.5), several io tests
    (testLongVol, testPNMReader, testVolReader, testCompressedVolWriter)
    fail if binary mode is not correctly set for iostreams.
    This commit makes these tests pass.
    BorisMansencal committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    b792378 View commit details
    Browse the repository at this point in the history
  2. Read only two characters for PGM header

    On Windows (with Visual Studio), the call to getline() may be found '\r' before '\n'.
    By restricting the header check to only two characters, we avoid this problem.
    This change makes testGenericReader and testGenericWriter pass.
    BorisMansencal committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    52ac7ca View commit details
    Browse the repository at this point in the history
  3. Explicit functors construction for Composer

    Build functors passed to Composer functor explicitly.
    This change makes testPNMRawWriter pass (with Visual Studio).
    BorisMansencal committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    97f4fd7 View commit details
    Browse the repository at this point in the history
  4. update Changelog

    BorisMansencal committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    1209a28 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Configuration menu
    Copy the full SHA
    2be8f9e View commit details
    Browse the repository at this point in the history
  2. update AUTHORS

    BorisMansencal committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    21012d9 View commit details
    Browse the repository at this point in the history