Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct EC command to fetch keyboard backlight level #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kelnos
Copy link

@kelnos kelnos commented May 29, 2024

The EC has a dedicated command for fetching the backlight level; use that instead of checking PWM duty cycle, which doesn't appear to work (catting the 'brightness' sysfs node always returns 0, regardless of the actual backlight level).

This is also what framework_tool does when passed '--kblight' with no options.

The EC has a dedicated command for fetching the backlight level; use
that instead of checking PWM duty cycle, which doesn't appear to work
(catting the 'brightness' sysfs node always returns 0, regardless of the
actual backlight level).

This is also what framework_tool does when passed '--kblight' with no
options.
@DHowett
Copy link
Owner

DHowett commented Jun 2, 2024

Thanks for the patch! An earlier version of this module did use EC_CMD_PWM_GET_KEYBOARD_BACKLIGHT -- however, on the Ryzen 7040 Framework Laptop 13 it reports that the backlight is disabled. It's fair enough to say that we should ignore that field. 🙂

@kelnos
Copy link
Author

kelnos commented Jun 3, 2024

Hm, I guess we could also detect the chipset/platform and act accordingly?

@kelnos
Copy link
Author

kelnos commented Jun 3, 2024

Also, does the duty cycle method work on the AMD board? And does the GET_KEYBOARD_BACKLIGHT command work? Just the enabled field is broken on the AMD board?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants