Merge pull request #243 from aldbr/main_FEAT_extension-management

feat: extension management

.github/DISCUSSION_TEMPLATE/user-personas-and-stories.yaml

@@ -4,7 +4,7 @@ body:
     attributes:
       value: >
         Develop a user persona and a story to capture the goals and tasks your users want to accomplish with diracx-web.
-        We are interested in understanding your needs and goals. Please focus on what you want to achieve rather than how you think it should be achieved.
+        We are interested in understanding your needs and goals. Please, first focus on what you want to achieve rather than how you think it should be achieved first.
         All ideas are welcome, and there are no wrong answers. We appreciate your honest feedback as it helps us improve the system to better meet your needs.
 
   - type: textarea
@@ -43,10 +43,27 @@ body:
     validations:
       required: true
 
+  - type: markdown
+    attributes:
+      value: |
+        From this point, you can optionally propose ideas of how it should be conceived, even if you technically do not know whether it is achievable.
+
   - type: textarea
-    id: additional-comments
+    id: design-solution
     attributes:
-      label: Additional Comments or Suggestions
-      description: "Share any other feedback, ideas, or suggestions that can help us understand your needs better."
-    validations:
-      required: false
+      label: Proposed Design Solution
+      description: |
+        Design proposal(s) can be submitted here.
+        Explain how your design solves the problem. Describe the design changes in details.
+      placeholder: "Describe your design solution..."
+
+  - type: markdown
+    attributes:
+      value: |
+        If possible, please attach an image representing a mockup or sketch of your design idea. Visual representations can help communicate your idea more clearly.
+
+  - type: markdown
+    attributes:
+      value: |
+        Once again, thank you for your contribution. Our team will review your design proposal(s) and provide feedback.
+

.github/workflows/basic.yml

@@ -3,28 +3,30 @@ name: Basic checks
 on:
   push:
     branches-ignore:
-      - dependabot/**
       - release-please-**
   pull_request:
     branches-ignore:
       - release-please-**
 
 jobs:
-  build:
+  basic-checks:
     runs-on: ubuntu-latest
-    if: github.event_name != 'push' || github.repository == 'DIRACGrid/diracx-web'
+    if: github.actor != 'dependabot[bot]' && (github.event_name != 'push' || github.repository == 'DIRACGrid/diracx-web')
     steps:
       - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
 
       - uses: actions/setup-node@v4
         with:
-          node-version: 'latest'
+          node-version: 'lts/*'
           cache: 'npm'
       - name: Install dependencies
         run: npm ci
 
+      # Build the library: needed to successfully run the following checks
       - name: Build Library
-        run: npm run build-lib
+        run: npm run build:diracx-web-components
 
       - name: Check formatting rules
         run: npx prettier . --check
@@ -33,3 +35,10 @@ jobs:
       - name: Check typescript type validity
         run: npm run ts-lint
 
+      - name: Validate current commit (last commit) with commitlint
+        if: github.event_name == 'push'
+        run: npx commitlint --last --verbose
+
+      - name: Validate PR commits with commitlint
+        if: github.event_name == 'pull_request'
+        run: npx commitlint --from ${{ github.event.pull_request.head.sha }}~${{ github.event.pull_request.commits }} --to ${{ github.event.pull_request.head.sha }} --verbose

.github/workflows/deployment.yml

@@ -28,6 +28,9 @@ jobs:
           config-file: release-please-config.json
           manifest-file: .release-please-manifest.json
 
+  # Library is built and deployed to NPM
+  # ------------------------------------
+
   build-deploy-library-package:
     runs-on: ubuntu-latest
     needs: release-please
@@ -40,7 +43,7 @@ jobs:
 
     - uses: actions/setup-node@v4
       with:
-        node-version: 'latest'
+        node-version: 'lts/*'
         registry-url: 'https://registry.npmjs.org'
 
     - name: Install dependencies
@@ -51,7 +54,10 @@ jobs:
     - name: Publish to NPM
       env:
         NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
-      run: npx lerna publish from-package --no-push --no-private --yes
+      run: npm publish from-package --no-push --no-private --yes
+
+  # Storybook is built and deployed to GitHub Pages
+  # -----------------------------------------------
 
   build-storybook-docs:
     runs-on: ubuntu-latest
@@ -64,11 +70,11 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: 'latest'
+          node-version: 'lts/*'
           cache: 'npm'
 
       - name: Build documentation
-        run: npm ci && npm run build-storybook -w @dirac-grid/diracx-web-components
+        run: npm ci && npm --prefix packages/diracx-web-components run build-doc
 
       - name: Upload artifact
         uses: actions/upload-pages-artifact@v3
@@ -88,9 +94,11 @@ jobs:
         uses: actions/deploy-pages@v4
         with:
           token: ${{ github.token }}
-
-
-  build-deploy-dev-image:
+
+  # diracx-web is built and deployed to GitHub Container Registry
+  # -------------------------------------------------------------
+
+  build-deploy-diracx-web-dev-image:
     runs-on: ubuntu-latest
     if: ${{ github.event_name != 'push' || github.repository == 'DIRACGrid/diracx-web' }}
     steps:
@@ -116,7 +124,7 @@ jobs:
           tags: ghcr.io/diracgrid/diracx-web/static:dev
           platforms: linux/amd64,linux/arm64
 
-  build-deploy-release-image:
+  build-deploy-diracx-web-release-image:
     runs-on: ubuntu-latest
     if: ${{ github.event_name == 'push' && github.repository == 'DIRACGrid/diracx-web' }}
     needs: release-please
@@ -142,31 +150,4 @@ jobs:
           context: .
           push: true
           tags: ghcr.io/diracgrid/diracx-web/static:${{ needs.release-please.outputs.tag_name }}
-          platforms: linux/amd64,linux/arm64
-
-  build-deploy-gubbins-image:
-    runs-on: ubuntu-latest
-    if: ${{ github.event_name == 'push' && github.repository == 'DIRACGrid/diracx-web' }}
-    needs: build-deploy-library-package
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Set up QEMU
-        uses: docker/setup-qemu-action@v3
-      - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
-
-      - name: Login to GitHub container registry
-        uses: docker/login-action@v3
-        with:
-          registry: ghcr.io
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Build Docker image (extension example)
-        uses: docker/build-push-action@v6
-        with:
-          context: ./packages/extensions
-          push: ${{ github.event_name == 'push' && github.repository == 'DIRACGrid/diracx-web' && github.ref_name == 'main' }}
-          tags: ghcr.io/diracgrid/diracx-web/static:extension-example
           platforms: linux/amd64,linux/arm64

.github/workflows/test.yml → .github/workflows/diracx-web-components-test.yml

@@ -1,27 +1,35 @@
-name: Tests
+name: DiracX-Web Components Tests
 
 on:
   push:
+    paths:
+      - 'packages/diracx-web-components/**'
+      - 'package.json'
+      - 'package-lock.json'
     branches-ignore:
       - dependabot/**
       - release-please-**
   pull_request:
+    paths:
+      - 'packages/diracx-web-components/**'
+      - 'package.json'
+      - 'package-lock.json'
     branches-ignore:
       - release-please-**
 
 jobs:
-  build:
+  test:
     runs-on: ubuntu-latest
     if: github.event_name != 'push' || github.repository == 'DIRACGrid/diracx-web'
     steps:
       - uses: actions/checkout@v4
 
       - uses: actions/setup-node@v4
         with:
-          node-version: 'latest'
+          node-version: 'lts/*'
           cache: 'npm'
       - name: Install dependencies
         run: npm ci
 
-      - name: Trigger tests
-        run: npm run test
+      - name: Trigger unit tests
+        run: npm --prefix packages/diracx-web-components run test

.github/workflows/integration-test.yml → .github/workflows/diracx-web-test.yml

@@ -1,7 +1,9 @@
-name: Integration Tests
+name: DiracX-Web Integration Tests
 
 on:
   push:
+    paths-ignore:
+      - 'packages/extensions/**'
     branches-ignore:
       - dependabot/**
       - release-please-**
@@ -24,6 +26,7 @@ jobs:
       run: |
         cd ..
         git clone https://github.com/DIRACGrid/diracx-charts.git
+
     - name: Start demo
       run: |
         cd ..
@@ -58,3 +61,4 @@ jobs:
       with:
         browser: chrome
         config: baseUrl=${{ env.DIRACX_URL }}
+        project: packages/diracx-web