Started on the DockerFiles #21
Conversation
Pedro-Roque
assigned Pedro-Roque, Jaeyoung-Lim and joris997 and unassigned Pedro-Roque and Jaeyoung-Lim
|
Additionally, we should try it with a clean jammy docker from here: Currently, there are some commands that remove fluff (e.g. zoom etc.) plus their desktop shortcuts, but that's a bit silly. |
| # rm -f /home/kasm-user/Desktop/sublime_text.desktop && \ | ||
| # rm -f /home/kasm-user/Desktop/telegram.desktop && \ | ||
| # rm -f /home/kasm-user/Desktop/Zoom.desktop && \ | ||
| # rm -f /home/kasm-user/Desktop/thunderbird.desktop |
There was a problem hiding this comment.
Is it worth using kasm if there is so much stuff that is not needed? We are pulling and then deleting stuff again.
There was a problem hiding this comment.
I agree with this @joris997 , is it possible to trim their original docker so that it doesn't install all this by default?
There was a problem hiding this comment.
I'm using kasm for the simple browser GUI support. In a command above, I mention that there is a clean jammy docker with kasm: https://hub.docker.com/r/kasmweb/core-ubuntu-jammy
but I haven't had time to test what will break w.r.t. the installation instructions.
I'm not that familiar with docker, so if there is a more lightweight option to get browser GUI support (or you want to go forward with another interface method), then let me know!
There was a problem hiding this comment.
The best approach would be start barebone and include only the necessary dependencies. This helps a) to identify dependencies so you can maintain them b) decrease the size of the docker, so you can save resources. This is not only on your local system, but has a huge impact when running CI.
If you are overwhelmed by this, PX4 already has a container maintained which includes a minimum set of dependencies: https://github.com/PX4/PX4-containers This may not be the minimum, but quite close.
There was a problem hiding this comment.
Does that provide a VNC instance ? Joris showed it running next to me and it seems convinient to just open the browser and have a desktop environment.
There was a problem hiding this comment.
If it doesn't have one we can add it 😄
There was a problem hiding this comment.
that would indeed be a nicer and lightweight solution. I will look into it this week @Jaeyoung-Lim
DockerFiles/run_kasm_ros.sh
Outdated
| # Run the Docker container | ||
| docker run -itd \ | ||
| --shm-size 32g \ | ||
| --runtime=nvidia \ |
There was a problem hiding this comment.
Does this mean that we have to have an nvidia gpu? Probably just check whether it exists before running it?
There was a problem hiding this comment.
good point. I will take this into account
There was a problem hiding this comment.
I've added a check for the existence of the nvidia-smi command.
|
I checked out the I've just committed code for a working core-ubuntu-jammy version that works. Issue is now that the resulting image size is somehow 57 GB :) I will try to fix this as using the bigger ubuntu-jammy-desktop image (with zoom, gimp, etc.) and running the commands manually in the docker led to an image size of 6.7 GB. |
|
@joris997 Why not just use the docker images distributed by docker? I still don't understand what we get from kasm. You can enable GUI without kasm |
|
@Jaeyoung-Lim do you have an example for this? I haven't worked much with docker + GUI support but just had good experience with kasm. |
I started on the dockerfiles with GUI support so that, with minimal effort, anyone can get the SITL simulation running.
Currently, I'm having issues with
sourcecommands ofsetup.bashfiles which break the docker (returning error code 1).To use it right now, follow the instructions in the README.md, but be advised that you need to run all commands by copying them from the complete docker file to the terminal in the docker instance.