feat(Docker): Dockerfile for comprising all the apps required for testing the PX4-space-system in a containarized system in any linux file #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect motor position
…ting the PX4-space-system in a containarized system in any linux file
…t launch the container as root
andre-rebelo-teixeira
pushed a commit
to SpaceBotsISR/PX4-Space-Systems
that referenced
this pull request
Oct 26, 2024
…le to parse multi line inputs (DISCOWER#23) Signed-off-by: frederik <[email protected]>
|
Hi Andre, this looks great! much cleaner than the draft I had in the other PR.
With that in mind, I tested the things you mentioned you tested in the readme.md, and it looks fine to me! |
|
@joris997 I'll wait for @andre-rebelo-teixeira to comment on the two items you have and then merge. Thanks for the contribution @andre-rebelo-teixeira ! |
|
The changes made look good. It was a lapse on my part default name of the master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this branch was to create a dockerfile than when compiled had all the necessary dependencies to run the simulator, this means that the Gazebo (with the custom gz-sim package), the custom QGroundControl, as well as the necessary ROS environment (ROS2 humble and the micro ros) for the simulation.
Currently the build stage of the docker is doing all the necessary steps, but more testing is necessary to make sure all the correct decencies.
Also the cloning of the PX4 repository to inside the docker container should be changed to a simple use of a shared folder in docker with the
-vflag on the docker run but some problem were found when this was being done