-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Améliorer la saisie avec un éditeur WYSIWYG #796
Open
yaaax
wants to merge
56
commits into
main
Choose a base branch
from
687-améliorer-la-saisie-erreurs-et-recommandations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "687-am\u00E9liorer-la-saisie-erreurs-et-recommandations"
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
d5003ef
to
2ba70c2
Compare
2ba70c2
to
31ce9e5
Compare
6672e96
to
b9a24e0
Compare
b9a24e0
to
1250bda
Compare
3251d48
to
9f3a245
Compare
75c5aeb
to
7981839
Compare
* Should handle existing markdown content * The editor is configured with extensions: * all what's in StarterKit * code block lowlight * highlight * link * task * typography (with french double quotes) * Some styles have been added to fit DSFR styling Still work in progress, but a nice start! To do: * image uploading and placement inside editor * menu buttons * accessibility tests and improvements
(and possibly importing JSON content?)
- backend: add a "system" module / controller / service - frontend: add a pruneUploads function to the existing system store TODO: add timestamps to AuditFile + check it when pruning
Could be bigger than 56rem. For example, when an image has not been loaded (e.g. URL not found), the width of the image is given by the `width` attribute.
Just cleaning
Retrieves all the keys of the files stored in the S3 bucket
Use env variable DEBUG="prisma:query" Note: queries using an existing connection are not properly logged (without var replacement) This could be improved when upgrading primsa
Add a new extension to handle visual decoration to selected block nodes without inline content (e.g. images) Before that, only single image selection was working. Now images look selected even when selecting a range of stuff (text+image+image for example)
* Modify ImageUploadTiptapExtension with an uploadFn parameter * Integrate Tiptap component in Criteria* components
Pruning uploads should not be possible from client web app. This is now only available on backend side. Code has been commented out in case we need to test it quickly for the web app.
63560a0
to
465801e
Compare
If not editable: * avoid adding useless functionnalities * do not display buttons
465801e
to
fb6476b
Compare
* require access token to prune images * add workflow to trigger pruning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still work in progress, but a nice start!
To do: