Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Améliorer la saisie avec un éditeur WYSIWYG #796

Open
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

yaaax
Copy link
Collaborator

@yaaax yaaax commented Aug 9, 2024

  • Should handle existing markdown content
  • The editor is configured with extensions:
    • all what's in StarterKit
    • code block lowlight
    • highlight
    • link
    • task
    • typography (with french double quotes)
  • Some styles have been added to fit DSFR styling

Still work in progress, but a nice start!

To do:

  • image uploading and placement inside editor
  • menu buttons
  • accessibility tests and improvements

@yaaax yaaax linked an issue Aug 9, 2024 that may be closed by this pull request
40 tasks
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-ejgfhq August 9, 2024 07:38 Inactive
@hissalht hissalht had a problem deploying to ara-687-ameliorer-la-sa-ejgfhq August 9, 2024 09:15 Failure
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-ejgfhq August 9, 2024 09:20 Inactive
@yaaax yaaax changed the title Add Tiptap and a first integration in NotesModal Améliorer la saisoe des erreurs Aug 9, 2024
@yaaax yaaax changed the title Améliorer la saisoe des erreurs Améliorer la saisie avec un éditeur WYSIWYG Aug 9, 2024
@yaaax yaaax force-pushed the 687-améliorer-la-saisie-erreurs-et-recommandations branch from d5003ef to 2ba70c2 Compare August 16, 2024 17:48
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-ejgfhq August 16, 2024 17:48 Inactive
@yaaax yaaax force-pushed the 687-améliorer-la-saisie-erreurs-et-recommandations branch from 2ba70c2 to 31ce9e5 Compare August 16, 2024 18:00
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-ejgfhq August 16, 2024 18:00 Inactive
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-ejgfhq August 17, 2024 18:24 Inactive
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-ejgfhq August 17, 2024 20:35 Inactive
@yaaax yaaax force-pushed the 687-améliorer-la-saisie-erreurs-et-recommandations branch from 6672e96 to b9a24e0 Compare August 17, 2024 20:44
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-ejgfhq August 17, 2024 20:44 Inactive
@yaaax yaaax force-pushed the 687-améliorer-la-saisie-erreurs-et-recommandations branch from b9a24e0 to 1250bda Compare August 19, 2024 09:59
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-ejgfhq August 19, 2024 09:59 Inactive
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-aargwr September 4, 2024 08:41 Inactive
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-aargwr September 4, 2024 09:15 Inactive
@yaaax yaaax self-assigned this Sep 5, 2024
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-aargwr September 13, 2024 14:00 Inactive
@yaaax yaaax force-pushed the 687-améliorer-la-saisie-erreurs-et-recommandations branch from 3251d48 to 9f3a245 Compare September 13, 2024 16:41
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-aargwr September 13, 2024 16:42 Inactive
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-itzbxb October 2, 2024 09:45 Inactive
@yaaax yaaax force-pushed the 687-améliorer-la-saisie-erreurs-et-recommandations branch from 75c5aeb to 7981839 Compare October 24, 2024 16:02
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-abtxfg October 29, 2024 11:08 Inactive
* Should handle existing markdown content
* The editor is configured with extensions:
  * all what's in StarterKit
  * code block lowlight
  * highlight
  * link
  * task
  * typography (with french double quotes)
* Some styles have been added to fit DSFR styling

Still work in progress, but a nice start!

To do:
* image uploading and placement inside editor
* menu buttons
* accessibility tests and improvements
(and possibly importing JSON content?)
yaaax added 14 commits January 21, 2025 15:49
- backend: add a "system" module / controller / service
- frontend: add a pruneUploads function to the existing system store

TODO: add timestamps to AuditFile + check it when pruning
Could be bigger than 56rem.
For example, when an image has not been loaded (e.g. URL not found), the width of the image is given by the `width` attribute.
Retrieves all the keys of the files stored in the S3 bucket
Use env variable DEBUG="prisma:query"

Note: queries using an existing connection are not properly logged (without var replacement)
This could be improved when upgrading primsa
Add a new extension to handle visual decoration to selected block nodes without inline content (e.g. images)
Before that, only single image selection was working.
Now images look selected even when selecting a range of stuff (text+image+image for example)
* Modify ImageUploadTiptapExtension with an uploadFn parameter
* Integrate Tiptap component in Criteria* components
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-d03ef2 January 29, 2025 14:34 Inactive
yaaax added 4 commits January 29, 2025 16:33
Pruning uploads should not be possible from client web app. This is now only available on backend side.
Code has been commented out in case we need to test it quickly for the web app.
@hissalht hissalht had a problem deploying to ara-687-ameliorer-la-sa-d03ef2 January 29, 2025 18:07 Failure
@yaaax yaaax force-pushed the 687-améliorer-la-saisie-erreurs-et-recommandations branch from 63560a0 to 465801e Compare January 29, 2025 18:13
@hissalht hissalht had a problem deploying to ara-687-ameliorer-la-sa-d03ef2 January 29, 2025 18:14 Failure
If not editable:
* avoid adding useless functionnalities
* do not display buttons
@yaaax yaaax force-pushed the 687-améliorer-la-saisie-erreurs-et-recommandations branch from 465801e to fb6476b Compare January 29, 2025 18:19
@hissalht hissalht temporarily deployed to ara-687-ameliorer-la-sa-d03ef2 January 29, 2025 18:19 Inactive
* require access token to prune images

* add workflow to trigger pruning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Améliorer la saisie erreurs et recommandations
2 participants