-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/resolve protocol fee calc error #231
Conversation
✅ Deploy Preview for mint-dlc-link ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for test-mint-dlc-link ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-mint-dlc-link ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, but I think this PR can handle another feature that this functions should be in a try catch and return 0 if any of these functions throw an error.
This pull request includes a modification to the
calculateProtocolFeeInUSD
function in thetransaction-screen.transaction-form.protocol-fee-box.tsx
file. The change involves adjusting the calculation of thefeeAmount
by using theunshiftValue
function.