Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/resolve protocol fee calc error #231

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

rozanagy
Copy link
Contributor

This pull request includes a modification to the calculateProtocolFeeInUSD function in the transaction-screen.transaction-form.protocol-fee-box.tsx file. The change involves adjusting the calculation of the feeAmount by using the unshiftValue function.

Screenshot 2025-01-21 at 13 39 41

@rozanagy rozanagy requested a review from Polybius93 January 21, 2025 12:40
Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for mint-dlc-link ready!

Name Link
🔨 Latest commit dcdbad6
🔍 Latest deploy log https://app.netlify.com/sites/mint-dlc-link/deploys/678fa656a329b60008e108e4
😎 Deploy Preview https://deploy-preview-231--mint-dlc-link.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for test-mint-dlc-link ready!

Name Link
🔨 Latest commit dcdbad6
🔍 Latest deploy log https://app.netlify.com/sites/test-mint-dlc-link/deploys/678fa6561745ad0009f3bfdc
😎 Deploy Preview https://deploy-preview-231--test-mint-dlc-link.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for dev-mint-dlc-link ready!

Name Link
🔨 Latest commit dcdbad6
🔍 Latest deploy log https://app.netlify.com/sites/dev-mint-dlc-link/deploys/678fa656e9a9b90008fc5f4b
😎 Deploy Preview https://deploy-preview-231--dev-mint-dlc-link.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Polybius93 Polybius93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, but I think this PR can handle another feature that this functions should be in a try catch and return 0 if any of these functions throw an error.

@rozanagy rozanagy merged commit 4383e20 into dev Jan 21, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants