-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add interface for replicated partition search #1286
base: main
Are you sure you want to change the base?
Conversation
Thank you for posting the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your Draft PR. it is looking good so far, we will discuss it further!
Can you add an author-file to /doc in the meantime?
Thank you for the feedback. I have added my author.txt and implemented your suggestions. |
Thank you! We are currently upgrading t8code to support C++17-features and want knew features to support this standart from the beginning on. We discuss what this means in detail for your feature and will keep you updated! |
We declare an interface for the search functionality. It is yet not implemented. A new templated search class and search_with_queries class that inherits from it.
Added the documentation of the search and search with query-class. Also started to implement the constructor, destructor and some convenience-functions
wip, does not compile at the moment. updated t8_gtest_search to use the new interface c-interface is currently untested, will probably need some changes for the callbacks.
in the callback the function t8_forest_get_tree_class throws an assertion. in the constructor of the test the same function is successfull.
pass forest explicitly
run with valgrind for more information
unref as destructor
when compiled with -pedantic reordering is forbidden
Hey @hannesbrandt we've worked on a cpp-interface for our current search-algorithms, which you can find in: Could you go in a similar direction with your implementation, please? |
…to feature-search_cpp_interface
…to feature-search_partition
I've added a cpp-interface for the partition search similar to the interface for the local search. Does this match your idea of what the interface should look like? |
Describe your changes here:
Add an interface for the partition search of a forest with replicated coarse mesh.
The interface coincides with the local search in large parts. The parameters
is_leaf, leaf_elements
andtree_leaf_index
are not available in the partition search and are replaced with the process range[pfirst,plast]
. Although all global trees are going to be traversed through use of the replicated coarse mesh, the tree id is provided as at8_locidx_t
as this matches the input parameters oft8_cmesh_get_tree_class
.All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.License
doc/
(or already has one)