Add Testing Participation Type #1941
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #1670. |
Riolku
force-pushed
the
testing-participation
branch
2 times, most recently
from
492a74c
to
3d9bafc
Compare
Riolku
force-pushed
the
testing-participation
branch
from
3d9bafc
to
ae3a400
Compare
As suggested, merge the access checks into one. Some tests had to be changed, because the old checks didn't check the dates.
Choose a scoreboard depending on the participation type. If the contest hasn't started, choose the testing scoreboard.
Riolku
force-pushed
the
testing-participation
branch
from
ae3a400
to
940794c
Compare
|
This PR needs some more unit tests for the new methods. I will do this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1886. Lots of code was refactored in order for this change to not be horrible to implement.
This is a hefty change, so testing from others would be appreciated.