Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We came across an issue in with the Org Links Validator last week that was being caused by an edge case.
The issue is that the
k
variable referenced in the validator does not exist.It was an edge case because the Org model defaults the value to
{"org":[]}
. We had some old records in our DB though that had a NULL value in the field, and our admin tried to merge one of them.To replicate the issue:
UPDATE orgs SET links = NULL WHERE id = ?;
valid?
method on the org somewhere in the code. We discovered it when trying to merge 2 orgs, but you could just as well add aputs @org.valid?
line on the "Org details" page.