Merge pull request #9 from DNXLabs/fix-deprecated-node-version

Fix deprecated node version
DNXLabs · Oct 30, 2023 · 31051bf · 31051bf
2 parents 3ea604b + d21cbd8
commit 31051bf
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -25,15 +25,16 @@ This module creates the "member" side of Guardduty, with the assumption that the
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
-| admin\_account\_id | GuardDuty Detector ID for master account | `any` | n/a | yes |
+| admin\_account\_id | GuardDuty Detector ID for master account | `string` | n/a | yes |
 | alarm\_slack\_severity | Minimum severity level (LOW, MEDIUM, HIGH) | `string` | `"HIGH"` | no |
 | alarm\_slack\_webhook | Slack Incoming Web Hook URL. Leave blank to disable alarm to slack | `string` | `""` | no |
+| create\_invite\_accepter | Create GuardDuty Member Invite Accepter. Not needed if already setup as part of an organization | `bool` | `true` | no |
+| enable\_detector | Enable GuardDuty Member Detector | `bool` | `true` | no |
 | enabled | The boolean flag whether this module is enabled or not. No resources are created when set to false. | `bool` | `true` | no |
 | lambda\_name | Name of the Lambda Function | `any` | n/a | yes |
+| member\_detector\_id | GuardDuty Detector ID for member account. Only needed if enable\_detector is false. Used for targeting any previously enable detector | `string` | `""` | no |
+| nodejs\_version | Version of Nodejs to create the lambda | `string` | `"nodejs18.x"` | no |
 | sns\_email\_arn | SNS Topic ARN | `string` | `""` | no |
-| enable\_detector | Enable GuardDuty Member Detector | `bool` | `true` | no |
-| create\_invite\_accepter | Create GuardDuty Member Invite Accepter. Not needed if already setup as part of an organization | `bool` | `true` | no |
-| member\_detector\_id | GuardDuty Detector ID for member account. Only needed if enable_detector is false. Used for targeting any previously enable detector | `string` | `""` | no |
 
 ## Outputs
 

diff --git a/_variables.tf b/_variables.tf
@@ -49,3 +49,9 @@ variable "member_detector_id" {
   type        = string
   default    = ""
 }
+
+variable "nodejs_version" {
+  type        = string
+  default     = "nodejs18.x"
+  description = "Version of Nodejs to create the lambda"
+}
diff --git a/guardduty-alarm-slack.cf.json b/guardduty-alarm-slack.cf.json
@@ -10,7 +10,8 @@
                   },
                   "Parameters": [
                       "IncomingWebHookURL",
-                      "MinSeverityLevel"
+                      "MinSeverityLevel",
+                      "NodejsVersion"
                   ]
               }
           ],
@@ -20,6 +21,9 @@
               },
               "MinSeverityLevel" : {
                   "default"  : "Minimum severity level (LOW, MEDIUM, HIGH)"
+              },
+              "NodejsVersion": {
+                  "default": "Version of Nodejs to create the lambda"
               }
           }
       }
@@ -39,7 +43,12 @@
               "MEDIUM",
               "HIGH"
           ]
-      }
+      },
+      "NodejsVersion": {
+        "Default": "node18.x",
+        "Description": "Version of nodejs to use to create the lambda",
+        "Type": "String"
+    }
   },
   "Resources": {
       "GuardDutyToSlackRole": {
@@ -225,7 +234,7 @@
                         "minSeverityLevel" : {"Ref" : "MinSeverityLevel"}
                     }
                 },
-                "Runtime": "nodejs12.x",
+                "Runtime": { "Ref": "NodejsVersion" },
                 "MemorySize" : "128",
                 "Timeout": "10",
                 "Description" : "Lambda to push GuardDuty findings to slack",

diff --git a/guardduty-alarm.tf b/guardduty-alarm.tf
@@ -14,6 +14,7 @@ resource "aws_cloudformation_stack" "guardduty_alarm_slack" {
   parameters = {
     IncomingWebHookURL = var.alarm_slack_webhook
     MinSeverityLevel   = var.alarm_slack_severity
+    NodejsVersion      = var.nodejs_version
   }
 
   template_body = file("${path.module}/guardduty-alarm-slack.cf.json")