-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACE6] Fixes for IPv6 multicast and inet_ntop/inet_pton on Windows #1352
Conversation
Also open a PR with the same change for master |
Sure. I am new to the process - should I have just opened this PR to the master, or should I have both PRs open in parallel? |
You can open both in paralllel when you want to have the change in ACE 7x and ACE 6.x |
@jwillemsen how do we see what actually failed? The "Details" link doesn't show anything |
I have the same issue in #1357 |
Strange, that worked in the past, maybe an issue on github actions currently, I restarted the failing checks |
Changed logic for GetAdaptersAddresses as per Microsoft guidelines:
https://docs.microsoft.com/en-us/windows/win32/api/iphlpapi/nf-iphlpapi-getadaptersaddresses
Fixed definitions for