Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACE6] Fixes for IPv6 multicast and inet_ntop/inet_pton on Windows #1352

Merged
merged 4 commits into from
Jan 5, 2021

Conversation

kuznetsovmoci
Copy link
Contributor

@kuznetsovmoci kuznetsovmoci commented Dec 23, 2020

Changed logic for GetAdaptersAddresses as per Microsoft guidelines:
https://docs.microsoft.com/en-us/windows/win32/api/iphlpapi/nf-iphlpapi-getadaptersaddresses

Fixed definitions for

#define ACE_LACKS_INET_NTOP
#define ACE_LACKS_INET_PTON

@jwillemsen
Copy link
Member

Also open a PR with the same change for master

@kuznetsovmoci
Copy link
Contributor Author

Also open a PR with the same change for master

Sure. I am new to the process - should I have just opened this PR to the master, or should I have both PRs open in parallel?

@jwillemsen
Copy link
Member

You can open both in paralllel when you want to have the change in ACE 7x and ACE 6.x

@mitza-oci mitza-oci changed the title Fixes for IPv6 on Windows [ACE6] Fixes for IPv6 on Windows Jan 4, 2021
ACE/ace/SOCK_Dgram.cpp Outdated Show resolved Hide resolved
ACE/ace/SOCK_Dgram.cpp Outdated Show resolved Hide resolved
ACE/ace/SOCK_Dgram.cpp Outdated Show resolved Hide resolved
ACE/ace/SOCK_Dgram.cpp Outdated Show resolved Hide resolved
ACE/ace/SOCK_Dgram.cpp Outdated Show resolved Hide resolved
ACE/ace/SOCK_Dgram.cpp Outdated Show resolved Hide resolved
ACE/ace/SOCK_Dgram.cpp Outdated Show resolved Hide resolved
ACE/ace/SOCK_Dgram.cpp Outdated Show resolved Hide resolved
@mitza-oci
Copy link
Member

@jwillemsen how do we see what actually failed? The "Details" link doesn't show anything

@iguessthislldo
Copy link
Member

how do we see what actually failed? The "Details" link doesn't show anything

I have the same issue in #1357

@jwillemsen
Copy link
Member

Strange, that worked in the past, maybe an issue on github actions currently, I restarted the failing checks

@mitza-oci mitza-oci changed the title [ACE6] Fixes for IPv6 on Windows [ACE6] Fixes for IPv6 multicast and inet_ntop/inet_pton on Windows Jan 5, 2021
@mitza-oci mitza-oci merged commit a43b786 into DOCGroup:ace6tao2 Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants