wxNamingViewer: build with wxWidgets 3.2 #2169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this. Would it be feasible to update one of the GitHub Actions builds to enable wxWidgets? |
saper
force-pushed
the
wxwidgets-3-2-support
branch
from
a13fcf5 to
d690c4d
Compare
wxNamingTree.cpp:94:45: error: non-const lvalue reference to type 'wxTreeItemIdValue'
(aka 'void *') cannot bind to a value of unrelated type 'long'
wxTreeItemId child = GetFirstChild( item, cookie);
^~~~~~
LLVM 16 fails to compile this, GetParent() seem to refer to wxWindow *GetParent() which has no args.
Going back to the source code from 2003, it seems that it has always should have been wxCommandEvent and not wxMouseEvent.
To get number of items in the container, GetCount() should be used. Hard to tell when Number() has been removed.
Sure, tried this 74ba32c but it looks like the build does not even descend into the |
|
It's running the makefile but not building anything yet. |
saper
force-pushed
the
wxwidgets-3-2-support
branch
from
74ba32c to
5ec78ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patches attached are needed to build and
run wxNamingViewer with wxWidgets 3.2
For most existing code I could not identify which version
of wxWindows/wxWidgets it could have worked last time,
therefore a generic #ifdef has been used.
If no support for old frameworks is needed,
those could be removed.