Add ACE_Auto_String_Free::operator bool

[likema]

For if (s) and if (!s)

Summary by CodeRabbit

• Refactor

  • Replaced 0 with nullptr for improved pointer initialization and type safety.
  • Added a boolean conversion operator to the ACE_Auto_String_Free class.
  • Updated constructors and methods for clarity in null pointer handling.

• Tests

  • Added new test function testAutoStringFree() to validate ACE_Auto_String_Free class behavior.

[jwillemsen]

Use nullptr, test missing

[coderabbitai]

Walkthrough

The pull request introduces modifications to the ACE library's string handling classes, focusing on improving null pointer handling and enhancing code clarity. Key changes involve replacing 0 with nullptr in several classes, including ACE_Auto_String_Free, ACE_NS_WString, and ACE_SString. The ACE_Auto_String_Free class gains a new boolean conversion operator for better pointer validity checks. Additionally, a new test function testAutoStringFree() is added to validate the functionality of the ACE_Auto_String_Free class.

Changes

File	Changes
ACE/ace/SString.cpp	- Simplified operator<< overload conditions - Replaced 0 with nullptr in pointer initializations and checks
ACE/ace/SString.h	- Updated constructor and reset method to use nullptr - Added explicit bool conversion operator to ACE_Auto_String_Free - Changed destructor to default
ACE/ace/SString.inl	- Replaced 0 with nullptr in pointer assignments and comparisons - Added bool conversion operator implementation
ACE/tests/SString_Test.cpp	- Added testAutoStringFree() function - Integrated new test into run_main()

Sequence Diagram

sequenceDiagram
    participant Client
    participant AutoStringFree
    participant Memory

    Client->>AutoStringFree: Create with pointer
    AutoStringFree->>Memory: Store pointer
    Client->>AutoStringFree: Check validity
    AutoStringFree-->>Client: Return boolean
    Client->>AutoStringFree: Reset/Destroy
    AutoStringFree->>Memory: Free memory

Loading

Poem

🐰 A Rabbit's Ode to Nullptr's Grace

In strings of code, where pointers dance,
Nullptr steps with elegant stance.
No more zero's ambiguous might,
Type-safe magic, pure and bright!
A cleaner path through memory's maze 🧀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cba1949 and fd04625.

📒 Files selected for processing (1)

• ACE/ace/SString.inl (6 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• ACE/ace/SString.inl

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Codacy Static Code Analysis

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.