Test and Potential Fix for Issue #363 Native Windows Condition Variables do not set errno to ETIME #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a wait on a condition variable times out. Added an additional case to the ACE_FAIL_RETURN macro to mutate ERROR_TIMEOUT into ETIME. Added an additional check at the end of the implementation of ACE_Condition<T>::wait(ACE_Time_Value*) to mutate WIN32 errors into errno (as expected).
|
FYI, because ACE_HAS_WTHREADS_CONDITION_VARIABLE is not defined by any of the CI or regular scoreboard builds none will test the core changes and the support for this |
jwillemsen
reviewed
Feb 8, 2017
|
|
||
| //============================================================================= | ||
| /** | ||
| * @file Native_Condition_Variable_Test.cpp |
There was a problem hiding this comment.
I would propose to remove Native_ from the name of this test, it just tests the condition variable behavior on any platform
There was a problem hiding this comment.
Agreed, I will probably change it to something like Condition_Variable_Timeout_Test.
…re general nature of the test and better indicate what is being tested.
…_RETURN now uses this method. Allows for a new macro ACE_FAIL_RETVAL which will mutate the last error and provide a value without requiring to return from a function. * Updated Win32 configuration to include native condition variables by default for Windows Vista / Windows Server 2008 and newer.
… checks correctly and not automatically default to Windows XP support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be worth considering revisiting the MSVC configuration files to enable ACE_HAS_WTHREADS_CONDITION_VARIABLE (with appropriate include statements) for Windows Vista/Server2008 and beyond.