Avoid allocating buffer when printing log.

[likema]

No description provided.

[jwillemsen]

With small embedded systems couldn't this lead faster to a stack overflow?

[likema]

The size of verbose buffer on stack is VERBOSE_LEN + 1 = 129.

Is it too large for embedded systems?

/// Size used by verbose mode.
/// 20 (date) + 15 (host_name) + 10 (pid) + 10 (type)
///           + 4 (@) ... + ? (progname)
VERBOSE_LEN = 128,

[jwillemsen]

I now see that you replaced MAXVERBOSELOGMSGLEN with VERBOSE_LEN which is much smaller, was that the intent?

[likema]

Yes. I separate a line of log message into a prefix (verbose buffer) and content so that only prefix needs a small buffer on stack.

[likema]

I find that

/// Size used by verbose mode.
/// 20 (date) + 15 (host_name) + 10 (pid) + 10 (type)
///           + 4 (@) ... + ? (progname)
VERBOSE_LEN = 128,

progname is not formatted into verbose buffer on stack. So VERBOSE_LEN can be reduce to
20 + 15 + 10 + 10 + 4 = 59

Please see also:

• ACE_TAO/ACE/ace/Log_Record.cpp

  Lines 250 to 252 in 9468af0

  	const ACE_TCHAR *verbose_fmt = ACE_TEXT_FMT ACE_TEXT ("@")
  	ACE_TEXT_FMT ACE_TEXT ("@%u@")
  	ACE_TEXT_FMT ACE_TEXT ("@");

• ACE_TAO/ACE/ace/Log_Record.cpp

  Lines 270 to 278 in 9468af0

  	const ACE_TCHAR *lhost_name = ((host_name == 0)
  	? ACE_TEXT ("<local_host>")
  	: host_name);
  	return ACE_OS::snprintf (verbose_msg, verbose_msg_size, verbose_fmt,
  	timestamp,
  	lhost_name,
  	this->pid_,
  	ACE_Log_Record::priority_name (
  	ACE_Log_Priority (this->type_)));

Am I right?

[mitza-oci]

Looks like this part would be useful in ace_wchar.h or OS_NS_stdio.h since other callers of ACE_OS::snprintf may need it.

[likema]

@mitza-oci Which name is better for it?

• ACE_TEXT_FORMAT_SPECIFIER
• ACE_STRING_FORMAT_SPECIFIER
• ACE_STR_FORMAT_SPECIFIER
• ACE_C_STRING_FORMAT_SPECIFIER
• ACE_C_STR_FORMAT_SPECIFIER

[mitza-oci]

This was added in #1907

[jwillemsen]

Looks I remembered correctly that there was a macro already, it was just not merged yet, thanks for linking Adam