Fix ACE_Stack_Trace potential buffer overflow. #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitza-oci
changed the title
likema
force-pushed
the
stack-strace-buffer-overflow
branch
2 times, most recently
from
cca348f to
2f8b3b4
Compare
likema
force-pushed
the
stack-strace-buffer-overflow
branch
from
2f8b3b4 to
63cef3f
Compare
|
Please don't use force push, the big disadvantage is that we can't see what has changed, so it would require a full new review of a change, when you want to update the branch with all recent changes just merge master again into your branch |
Sorry, OK |
mitza-oci
requested changes
Apr 28, 2020
| @@ -92,7 +92,7 @@ ACE_Stack_Trace::generate_trace (ssize_t starting_frame_offset, size_t num_frame | |||
| stack_syms = ::backtrace_symbols (stack, stack_size); | |||
|
|
|||
| for (size_t i = starting_frame; | |||
| i < stack_size && num_frames > 0; | |||
| i < stack_size && num_frames > 0 && this->buflen_ < SYMBUFSIZ - 1; | |||
There was a problem hiding this comment.
Suggested change
| i < stack_size && num_frames > 0 && this->buflen_ < SYMBUFSIZ - 1; | |
| i < stack_size && num_frames > 0 && this->buflen_ < SYMBUFSIZ - 2; |
Needs space for \n and \0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.