Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SSL read/write queues. #952

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

sonnin
Copy link

@sonnin sonnin commented Aug 26, 2019

Comments in the code states below:
// only one read operation is allowed now
// later it will be possible to make a queue

Somehow our usage of ACE 6.1.7 hits this limitation in some situations. Resulting in read/write errors.

Adding read/write queues resolves this limitation.

SSL connection was unstable on high load
@jwillemsen jwillemsen added the needs review Needs to be reviewed label May 7, 2020
@jwillemsen
Copy link
Member

Some fuzz errors

Running NULL usage check
Error: ./ACE/ace/SSL/SSL_Asynch_Stream.cpp:342: NULL found
Error: ./ACE/ace/SSL/SSL_Asynch_Stream.cpp:382: NULL found

@jwillemsen
Copy link
Member

Do you have an extension or new ACE unit test to validate this new code?

@sonnin
Copy link
Author

sonnin commented May 18, 2020

Do you have an extension or new ACE unit test to validate this new code?

No.

The existing test should continue to work. But will only test with one message in the queue. Hence the FIFO logic is not validated by test cases.

@jwillemsen
Copy link
Member

Can you extend the exiting test to also test the FIFO logic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Needs to be reviewed
Development

Successfully merging this pull request may close these issues.

2 participants