Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stdafx.h to project #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add stdafx.h to project #81

wants to merge 1 commit into from

Conversation

LukeMouse
Copy link
Contributor

No description provided.

@@ -799,6 +799,9 @@
<%endif%>
<%if(header_files)%>
<ItemGroup>
<%if(pch_header)%>
Copy link
Member

@jwillemsen jwillemsen Mar 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When header_files is empty and pch_header is set it will not be generated? Also when pch_header is added also by the user to header_files it will be duplicate which prevents the solution from being loaded by visual studio

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes,it work well under vs2008 but failed under vs2015

Copy link
Member

@jwillemsen jwillemsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enhance the extension so that it also works with vs2015 in all cases

@LukeMouse
Copy link
Contributor Author

LukeMouse commented Apr 10, 2019

I cant catch what your means "works with vs 2015 in all cases", I add this segment reference form the pch_souce config in the next part as follow:
<%if(source_files)%>
< ItemGroup >
<%if(pch_source)%>
< ClCompile Include="<%pch_source%>" >
<%foreach(platforms)%>
<%foreach(configurations)%>
< PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='<%configuration% >|<%platform%>'">Create</ PrecompiledHeader >
<%endfor%>
with only this segment only pch_souce file being added to the project, so I try to add my segment page, with new added segment the pch_header appeared in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants