point to specific files for updates #79
Conversation
| self.d3.csv("https://labs.waterdata.usgs.gov/visualizations/data/gw-conditions-site-coords.csv", this.d3.autotype), | ||
| self.d3.csv("https://labs.waterdata.usgs.gov/visualizations/data/gw-conditions-daily-proportions.csv", this.d3.autotype), | ||
| self.d3.csv("https://labs.waterdata.usgs.gov/visualizations/data/gw-conditions-daily-proportions-wy22.csv", this.d3.autotype), |
There was a problem hiding this comment.
This seems like a good change to make, but should there be a corresponding change to the filename in 3_visualize.yml? Are you making the edit manually right now? I see you make a copy of the file with the dates in the filename further down. Should that be used here instead? And should this comment be updated to note that the file will need to be manually updated in GWL.vue?
There was a problem hiding this comment.
Yes you are absolutely correct. However, this puts the data in the dev s3 bucket which cannot be accessed through a url in the browser. I did this manually as a band-aid to get the correct data showing for the last WY. We need to refine this piece, also to consider how we will set up to be able to change the dates to regenerate each month.
There was a problem hiding this comment.
We could redirect this to the public bucket instead of the dev as a solution. Definitely don't need to keep both. Also should consider how long we should store these updates once we have a routine down
There was a problem hiding this comment.
Cool, sounds good. I'll make an issue with these notes, and then this is good to merge
There was a problem hiding this comment.
Good to go - added issue #80 documenting how we'd like to refine the s3 approach.
|
A potential issue - I just started working w/i this branch to make the visual for social media and noticed a couple of odd things:
But that doesn't seem to reflect the starting conditions, if I play and immediately pause:
|
|
1 is a known issue with the first draw. I haven't been able to get to it yet https://github.com/USGS-VIZLAB/gw-conditions/issues/48The issue is that the svg that loads with the map initially represents 1 day of data, that is seemingly tied to the prior year's data. It must be that somewhere in the pipeline the map is created but is not linked to the updating data, or that we only created this once. This is set up like this because we wanted the map to appear right away when the page loads, and requiring the data to load first to be able to draw the map all in D3 was slow. Now, it loads a pre-defined svg and then when the data loads, binds it to the sites. This could be related to 2 also because if there were changes in sites between years, sites from last year may be loading and never getting data assigned, and remaining static on the page. 2 is suspicious and may be related to 1 if NA values are defaulting to the first draw state? also possible this is related to the different pcodes in FL. Will look into this before moving forward. |
Designating the file vue reads in from s3 to avoid unintended updates from re-running the pipeline locally before ready to deploy.
This should create the ready-to-release update for the 2022 water year.