-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set DOMserver IPs #167
Set DOMserver IPs #167
Conversation
See Pat's list, I'm not sure about the analyst instance if that is the host `green` or the host `analyst-green`, went with the `analyst-green`. Onsite we should discuss which machine will be dualhomed or which firewall can be changed so we can manage the analyst instance.
This is needed because of the replication password, alternative would be to do the same split as for online and not have so many groups in groups but that also makes that we duplicate a lot of settings.
We now share all variables between both domservers so they share all facts. Only the passwords are changed to make sure no data can leak if we misconfigure the domserver URL in the analyst instance.
1aa130e
to
bf21d43
Compare
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
6152503 | Triggered | Generic Password | 7730200 | provision-contest/ansible/group_vars/onprem/secret.yml.example | View secret |
9997180 | Triggered | Username Password | 7730200 | provision-contest/ansible/group_vars/onprem/secret.yml.example | View secret |
9997181 | Triggered | Generic Password | 7730200 | provision-contest/ansible/group_vars/onprem/secret.yml.example | View secret |
6152502 | Triggered | Generic Password | 7730200 | provision-contest/ansible/group_vars/onprem/secret.yml.example | View secret |
6152499 | Triggered | Generic Password | 7730200 | provision-contest/ansible/group_vars/onprem/secret.yml.example | View secret |
6152500 | Triggered | Generic Password | 7730200 | provision-contest/ansible/group_vars/onprem/secret.yml.example | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
||
PHPSTORM_VERSION: 2022.2 | ||
PHPSTORM_FULL_VERSION: 222.4345.15 | ||
|
||
GRAFANA_MONITORING: false | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropping all this means we have no example of it anymore on main. Does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, forgot to change the base to wfastana
.
d5303d7
to
da44bcd
Compare
See Pat's list, I'm not sure about the analyst instance if that is the host
green
or the hostanalyst-green
, went with theanalyst-green
.Onsite we should discuss which machine will be dualhomed or which firewall can be changed so we can manage the analyst instance.
This also requires a split in grouping to make sure that the analyst instance doesn't get a replication setup. It wouldn't hurt but its better to not install extras which are not needed as it opens up the sql server there in green.