Extend autoconf tests #2975
Open
Extend autoconf tests #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
configure_test_build_gha_subjobs
branch
3 times, most recently
from
a6c8f36 to
1236996
Compare
It uses wwwrun (or www group), it's added as last so it shouldn't fail our normal installs.
vmcj
force-pushed
the
configure_test_build_gha_subjobs
branch
from
223665f to
8a60b1b
Compare
sphinx-build adds it's own Makefile which we need to work around or we can decide to just remove all dirs. This would also remove custom files someone might have put there.
It's always run before every testcase, which makes that we would always install certain tools which breaks the tests where we assume to not have those tools.
Bats testing now works from another directory
We'll need to start with multiple clean images in future tests so we now skip certain tests to keep a "clean" image for certain tests and test in other matrix jobs. The intent was to both extend the tests and test with different distrobutions: - Alpine fails on running bats, - Fedora has issues with building `runpipe` so fails on `make judgehost` - Arch needs another package manager to install certain libraries (so is left for another PR). - OpenSUSE lacks some libraries. The pre-work is already done to start using those images. make clean should remove what was created by make all make distclean should remove what was created by configure (plus what make clean does)
vmcj
force-pushed
the
configure_test_build_gha_subjobs
branch
from
8a60b1b to
a6668ba
Compare
|
The PR should be fine without the Not sure why https://github.com/DOMjudge/domjudge/actions/runs/14092975984/job/39473975481#step:4:1010 fails, @eldering shouldn't it find the target because of the Makefile.global? Other files also don't have an explicit dependency for distclean to depend on clean so what is it complaining about? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to split tests where extra packages get installed to different runs.
It does add some small improvements to the configure script to make testing easier.