Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix-1786][chunjun-metrics-prometheus] Fix uploading of startLocat… #1894

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Icarus-Alpha
Copy link

Fix uploading of startLocation and endLocation metrics to PushGateway

Purpose of this pull request

This pull request addresses an issue with the Chunjun data integration platform where specific metrics, startLocation and endLocation, were not being uploaded to the Prometheus PushGateway. This failure in metrics reporting has significant implications for monitoring and troubleshooting data synchronization tasks, as these metrics are crucial for understanding the data flow and pinpointing where discrepancies occur. The fix introduces modifications to ensure that these metrics are captured accurately and transmitted to the Prometheus PushGateway, enhancing observability and reliability of data synchronization processes in environments using different versions of Flink.

Which issue you fix

Fixes #1786

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[hotfix-1786][chunjun-metrics-prometheus] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@Icarus-Alpha
Copy link
Author

PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant