Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feature/kalman, TMS_Bar and TMS_Kalman small changes #167

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

LiamOS
Copy link
Member

@LiamOS LiamOS commented Oct 1, 2024

config/TMS_Default_Config.toml:

  • FirstCluster now set to 'false' by default

TMS_Bar:

  • Added GetBarWidth() and GetBarLength(), Width/Length are always the short/long bar dimension respectively

TMS_Kalman:

  • cout and cerr output much more tolerable
  • Check on initial Y slope for some tracks
  • Better check on values while constructing nodes
  • Can now handle horizontal (X) layers in theory, untested
  • Detector noise matrix calculated using layer geometry (from TMS_Bar additions above)
  • Chi2 calculated per-node, can be summed for a track
  • KalmanErrorDetVol variable added, 1 if Kalman filter predicts a node outside the scintillator, 0 otherwise

TMS_Reco

  • SetStart/EndDirection is previously only called for tracks when Kalman was run, now set it as start-end (old way) if Kalman isn't run.

TMS_Track

  • SetStartDirection/SetEndDirection now automagically normalise the vectors given to them.
  • Chi2 variable added per track, to be filled by Kalman (in future maybe chi2_mu / chi2_amu?)
  • KalmanErrorDetVol propagated to TMS_Track object

TMS_TreeWriter

  • RecoTrackHitPos and related now include time, and thus have an extra index ([3] -> [4]).
  • Added Chi2 to output files, filled by RecoTrackChi2 in TreeWriter.cpp
  • KalmanErrorDetVol included in output trees per track

@LiamOS LiamOS added the enhancement New feature or request label Oct 1, 2024
@LiamOS LiamOS requested review from jdkio and AsaNehm October 1, 2024 15:26
@LiamOS LiamOS self-assigned this Oct 1, 2024
@LiamOS
Copy link
Member Author

LiamOS commented Oct 1, 2024

Should be behaving substantially better with this, but not perfect. Still leaves the detector sometimes. Want to wait for some feedback for Asa before tackling this fully.

Copy link
Contributor

@AsaNehm AsaNehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config change I fully approve. The Bar stuff looks reasonable. For the Kalman stuff I read through it, but I don't have the time to fully understand it, so I'll trust you on this

@LiamOS
Copy link
Member Author

LiamOS commented Oct 14, 2024

Validation plots from one file located in /exp/dune/data/users/losulliv/dune-tms/Validation/Reco_Tracks/MicroProdN1p1_NDLAr_1E18_RHC.spill.nu.0000120.EDEPSIM_SPILLS_TMS_RecoCandidates_Hough_Cluster1_images/

For future PRs, should we define some minimal set of required validation plots that should be presented, or do it depending on the content of the PRs?

@AsaNehm
Copy link
Contributor

AsaNehm commented Nov 14, 2024

Solved merging conflict by removing the sanity check in TMS_Bar that was still in in this branch but removed on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants