Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the light noise issue #202

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix the light noise issue #202

merged 1 commit into from
Feb 15, 2024

Conversation

YifanC
Copy link
Collaborator

@YifanC YifanC commented Feb 15, 2024

Link to issue #196 and #197 .

@krwood
Copy link
Member

krwood commented Feb 15, 2024

Can you comment on the checks that have been done with this PR? Any before vs. after validations plots?

@YifanC
Copy link
Collaborator Author

YifanC commented Feb 15, 2024

The before and after plots are linked in Issue #196.
Before 1:
empty_light_wvfm_no_noise
Before 2:
empty_light_wvfm_separate_noise_all
After:
empty_light_wvfm_fixed_noise_all

@YifanC YifanC merged commit 864139b into develop Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants