Custom slot for spectrum gloves #686
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike most glove trinkets added by other mods, Spectrum's gloves each represent a pair of gloves rather than a singular glove, and thus Spectrum only enables one of the two glove slots to put them in. This causes jank when another mod that enables both glove slots is installed, as the Spectrum gloves can only go in one of the two slots with no immediate indication as to why.
This PR solves the issue by creating a custom
glovesslot for Spectrum's gloves to go in. Now that the gloves have their own dedicated slot, there will no longer be any confusion as to why they can only fit in one of the two identical glove slots used by most other mods, and their mutual exclusivity with each other is still maintained.