Migrate to new 32blit wave API #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daft-Freak
reviewed
Jan 27, 2021
Update for the API changes in 32blit/32blit-sdk#562
Gadgetoid
force-pushed
the
patch-sound-new-wave-api
branch
from
eeddd31 to
938ed70
Compare
|
Sound is now ... sounding... but even with Music Volume cranked up to max, it seems to be noticeably quieter than the SFX at 50%. |
|
Sounds about the same as before... (Probably the magic number here needs adjusting, I just went for max loudness). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for the API changes in 32blit/32blit-sdk#562
Doesn't.... seem to work... 😬