Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-create https://github.com/Dallinger/Griduniverse/pull/277/ off the main branch #294

Closed
wants to merge 1 commit into from
Closed

Re-create https://github.com/Dallinger/Griduniverse/pull/277/ off the main branch #294

wants to merge 1 commit into from

Conversation

stugots
Copy link
Collaborator

@stugots stugots commented Nov 6, 2024

See #268 #269

alecpm
alecpm approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@alecpm alecpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I got a little confused by the re-ordering of params, which looked like a mass removal at first. That's probably going to cause some merge conflicts with open PRs, but they should be simple enough to resolve.

alecpm
alecpm requested changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@alecpm alecpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke too soon, there's a conflict that needs to be resolved before this can be merged.

@jessesnyder
Copy link
Contributor

I think this PR is now redundant with already merged work:
#296

@stugots Does that sound right to you?

@stugots
Copy link
Collaborator Author

stugots commented Nov 13, 2024

@jessesnyder Yes

@jessesnyder
Copy link
Contributor

Redundant with #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecpm alecpm alecpm requested changes

@jessesnyder jessesnyder Awaiting requested review from jessesnyder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stugots @jessesnyder @alecpm