-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support to FILE suffix #7
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request. Looking pretty good - one quick question below.
@@ -41,13 +64,13 @@ if [ "$1" = 'postgres' ]; then | |||
echo "Waiting for master to ping..." | |||
sleep 1s | |||
done | |||
PGPASSWORD=${POSTGRES_PASSWORD} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if only PGPASSWORD is set & POSTGRES_PASSWORD isn't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the question, POSTGRES_PASSWORD
has to be set, otherwise the scripts will not work regradless of my change, am I missing something?
the reason I added PGPASSWORD=${POSTGRES_PASSWORD}
is to make the ping to master to work, since this script need the password in order to work
I apologize I did not previously have time to properly review and merge your work. I've created a new patch based build process on the dev branch, and builds from this process temporarily live at https://hub.docker.com/r/danieldent/docker-postgres-replication-dev/ until I and other community members have had a chance to test these updates (the new build process also builds the -alpine variants as well as Postgres 10). I have not had time to even run these new builds, so please run this builds in test prior to dropping them into a production environment. |
The FILE suffix is supporeted in docker-entry of postgres image, but was removed when the ./docker-entry.sh was overriden
so I added that support,
also the
setup_replication.sh
f needed the password that comes from file, so I added that there as well