-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perk p2 single #25
Perk p2 single #25
Conversation
Constructor modified
Add constructor of PERK3
Co-authored-by: Daniel Doehring <[email protected]>
Perk p2p3 single
… into PERK_p2p3_Single
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Warisa, Thanks four your work!
We should provide a functionality such that the user can send in a list of eigenvalues, see the comments. In case of questions contact me on Slack!
src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/polynomial_optimizer.jl
Outdated
Show resolved
Hide resolved
Close this one for now. Working on making Convex and ECOS extensions rather than direct dependencies. |
Hello,
I hope you are having a nice day!
I have created this new branch without p3 content and added the elixir to this file https://github.com/trixi-framework/Trixi.jl/blob/main/test/test_tree_1d_advection.jl like you instructed. Please let me know if I misunderstood or missed something.