Skip to content
This repository has been archived by the owner on Apr 25, 2020. It is now read-only.

Multiple files #137

Merged
merged 5 commits into from
Sep 4, 2013
Merged

Multiple files #137

merged 5 commits into from
Sep 4, 2013

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Aug 21, 2013

Allows type checking multiple files at once (faster).

I've implemented it for check and expand; probably the other options could benefit from this as well.

@nh2
Copy link
Contributor Author

nh2 commented Aug 21, 2013

(I would also love to have this in hdevtools.)

@kazu-yamamoto
Copy link
Collaborator

The idea looks good. However, I think you implemented your idea on a too old revision. It's tough to merge. Please re-implement it on the latest code and give me a pull request again.

@nh2
Copy link
Contributor Author

nh2 commented Aug 23, 2013

Oh, I missed the old revision. I updated it.

@kazu-yamamoto
Copy link
Collaborator

@nh2 Are you working with this? I can spend my time for ghc-mod in September.

@nh2
Copy link
Contributor Author

nh2 commented Sep 3, 2013

Yes, it does work for me so far.

A small benchmark:

time sh -c 'for f in `echo Data/Aeson/Encode.hs Data/Aeson/Functions.hs Data/Aeson.hs Data/Aeson/Parser.hs Data/Aeson/Parser/Internal.hs Data/Aeson/TH.hs Data/Aeson/Types/Class.hs Data/Aeson/Types.hs Data/Aeson/Types/Internal.hs`; do echo $f; ghc-mod check $f; done' 
Data/Aeson/Encode.hs
Data/Aeson/Functions.hs
Data/Aeson.hs
Data/Aeson/Parser.hs
Data/Aeson/Parser/Internal.hs
Data/Aeson/TH.hs
Data/Aeson/Types/Class.hs
Data/Aeson/Types.hs
Data/Aeson/Types/Internal.hs
4.86s user 0.46s system 99% cpu 5.323 total

time ghc-mod check Data/Aeson/Encode.hs Data/Aeson/Functions.hs Data/Aeson.hs Data/Aeson/Parser.hs Data/Aeson/Parser/Internal.hs Data/Aeson/TH.hs Data/Aeson/Types/Class.hs Data/Aeson/Types.hs Data/Aeson/Types/Internal.hs               
1.46s user 0.11s system 99% cpu 1.578 total

@nh2
Copy link
Contributor Author

nh2 commented Sep 3, 2013

I've rebased my commits on the current master.

@nh2
Copy link
Contributor Author

nh2 commented Sep 3, 2013

(I would also love to have this in hdevtools.)

bitc/hdevtools#18

@alanz
Copy link
Collaborator

alanz commented Sep 3, 2013

It will also help the case for me where I want to refactor the library, executable and tests for a given project at the same time. Can make sure it is all loaded, and the changes propagate everywhere.

kazu-yamamoto added a commit that referenced this pull request Sep 4, 2013
@kazu-yamamoto kazu-yamamoto merged commit 496f53a into DanielG:master Sep 4, 2013
@kazu-yamamoto
Copy link
Collaborator

Thank you. I have merged. I will release a new version ASAP.

@alanz
Copy link
Collaborator

alanz commented Sep 4, 2013

When you are ready. I have locked the upper bound on HaRe for now, will
integrate when it is convenient

On Wed, Sep 4, 2013 at 3:14 AM, Kazu Yamamoto [email protected]:

Thank you. I have merged. I will release a new version ASAP.


Reply to this email directly or view it on GitHubhttps://github.com//pull/137#issuecomment-23759630
.

@kazu-yamamoto
Copy link
Collaborator

I have just released a new version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants