forked from aws-observability/aws-otel-test-framework
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdk_framewrok -> New schema for validationa and new config format #9
Open
Danielzolty
wants to merge
14
commits into
terraform
Choose a base branch
from
cdkSchema
base: terraform
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding cluster deployment folder * Added deployment_cluster * changed parent stack props and created sets for validation * put all clusters in one child stack and exposed them * Made code tweaks to deployment * Fixed bugs with cluster deployment * Fixed bugs with cluster deployment * organization changes plus resource stack added * design change - no clusterManagementStack * validate method call fix * Changed to ICluster + NestedStack -> Stack * changed map to hold stacks instead of clusters * Changed location for resource deployment * added awsAuth to clusters * Added verification check * added verfication check * deleted unnecessary files * added tests * Changed some function names * changed repo name * Added REAMDE * Minor changes * removed 1.22 version option * couple styling changes * fixed awsAuth * deleted backslashed lines * Put everything under EKS folder * Updated ReadMe * Delete deployment_clusters directory * removing cluster_deployment_example module * Made some of the suggested changes * New changes corresponding to new config format * Update README.md * added new lines at end of bunch of files * New PR changes * Updated README and fixed validation error message * made changes to ReadMe * Unit test changes, linter fixes, readme update * Added Makefile * Needed to unshade line in makefile * Changed placement of vpc stack, switched to single quotes, and renamed validation file * Forgot to save test file * Changed format * changed directory structure * Added testcase config * Added files for Mayer * added stuff to readme and destroy target to makefile * fixed quick bug in makefile * deleted targets from makefile * some changes to readme and makefile * Made PR changes * Added couple comments and created default case in switch case in cluster validation * Added design.md * Update DESIGN.md * Added to design.md * Finished first draft of Design.md * Edited Design.md * Added ReadMe update, newlines, and made availability zones more flexible * Added example case in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.