Merge pull request #668 from noproto/patch-1

Fix edge case -- 0.5% of UIDs got wrong result
DarkFlippers · Dec 13, 2023 · 09a66e2 · 09a66e2
2 parents fb17718 + 3dde112
commit 09a66e2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/applications/main/nfc/plugins/supported_cards/saflok.c b/applications/main/nfc/plugins/supported_cards/saflok.c
@@ -62,8 +62,8 @@ void generate_saflok_key(const uint8_t* uid, uint8_t* key) {
     uint8_t carry_sum = 0;
 
     for(int i = KEY_LENGTH - 1; i >= 0; i--, magickal_index--) {
-        uint16_t keysum = temp_key[i] + magic_table[magickal_index];
-        temp_key[i] = (keysum & 0xFF) + carry_sum;
+        uint16_t keysum = temp_key[i] + magic_table[magickal_index] + carry_sum;
+        temp_key[i] = (keysum & 0xFF);
         carry_sum = keysum >> 8;
     }