Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role Restriction Removal #1305

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

Aegledis
Copy link
Contributor

About The Pull Request

Removes most gender restrictions (Yes, this PR makes female inquisitors a reality). Makes racial restrictions more lax as well. (Don't worry, tieflings and dark elves are still not allowed to be court roles.)

Why It's Good For The Game

Player freedom. Gets rid of non-sensical changes like preventing tieflings to be stevedores or preventing females to be swordmasters.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@@ -25,9 +25,9 @@
H.change_stat("speed", -1)
var/prev_real_name = H.real_name
var/prev_name = H.name
var/honorary = "Ritter"
var/honorary = "Retter"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again. No.

@@ -53,7 +53,7 @@
var/prev_real_name = H.real_name
var/prev_name = H.name
if(H.dna.species?.id != "abyssariad")
var/honorary = "Sir"
var/honorary = "Ser"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, no as well. Never.

@sanshoom
Copy link

i thought women couldn’t be swordmasters because they didn’t have sprites. same for female longbeards.

@DovaKitty
Copy link
Contributor

i thought women couldn’t be swordmasters because they didn’t have sprites. same for female longbeards.

That is the reason, yes.

@DovaKitty
Copy link
Contributor

This PR would break classes as they don't have the proper sprites for female bodies. Also changes the title names for classes which was previously reverted without putting it into the PR descriptions.

Did not document all of its changes and would break the classes it's trying to 'fix'. 2/10 PR.

@Optimism333
Copy link
Contributor

Dova does plan to create female inquisitors, they would come with the Amazonian lodge. I believe he also had a plan to make a Zybantu inquisitor, which might have the option to choose male or female? The current inquisitor is the Grenzelhoft inquisitor, and they are a male only order, hence the restriction.

Frankly I think having different Inquisition lodges with culture/lore and allowed genders is far more interesting than just bulldozing the male-only restriction. They're one of the only roles left with such a restriction, anyways. Why cut the tape when nearly every other role already allows player freedom in that regard?

Also yes, unless you're adding female sprites for the swordsmaster armor, the armor will just not show up if someone picks female and chooses that role.

@Aegledis
Copy link
Contributor Author

i thought women couldn’t be swordmasters because they didn’t have sprites. same for female longbeards.

I'm aware. Mono said they would do the sprites.

@Aegledis
Copy link
Contributor Author

Dova does plan to create female inquisitors, they would come with the Amazonian lodge. I believe he also had a plan to make a Zybantu inquisitor, which might have the option to choose male or female? The current inquisitor is the Grenzelhoft inquisitor, and they are a male only order, hence the restriction.

Frankly I think having different Inquisition lodges with culture/lore and allowed genders is far more interesting than just bulldozing the male-only restriction. They're one of the only roles left with such a restriction, anyways. Why cut the tape when nearly every other role already allows player freedom in that regard?

Also yes, unless you're adding female sprites for the swordsmaster armor, the armor will just not show up if someone picks female and chooses that role.

Dova has announced an Inquisitor PR long ago and nothing has came out of it yet. Until then, I believe letting female characters play inquisitor is in order.

Regarding female sprites for the swordsmaster, Mono should be working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants