Casket pr #6320

Omnione · 2019-12-07T21:06:43Z

Added all the remaining zone casket npc scripts.
Added all zone mixins for caskets.
Added all temp items that caskets use.
Edited 2 effects that were not implimented.

I have spent many hours going over the drop rates of items, if anyone wants to make adjustments feel free to PR them if you feel they are off but right now they are as retail as i could get with limited info, but they feel right when playing.

scripts/globals/caskets.lua

TeoTwawki

All minor issues, nothing serious:

The temp items in this PR do not medicate on retail. (esp. pet item lol)
The %hp and %hp code can be simplified
Status effect removal code can be made smaller
A few of them tabs snuck in. NINJAS!

scripts/globals/items/bottle_of_ascetics_gambir.lua

scripts/globals/items/bottle_of_ascetics_tonic.lua

scripts/globals/items/bottle_of_catholicon.lua

scripts/globals/items/bottle_of_catholicon_+1.lua

scripts/globals/items/bottle_of_catholicon.lua

scripts/globals/items/dusty_elixir.lua

scripts/globals/items/flask_of_healing_powder.lua

scripts/globals/items/tube_of_healing_salve_i.lua

scripts/globals/items/tube_of_healing_salve_ii.lua

wrenffxi · 2019-12-07T23:52:26Z

I double-checked all the tabled itemIds against the database to see if they matched the items named in LUA comments.

Found no incorrect itemids. ✅

~~Only discrepancy, if you can call it that, is that the commented item names are misordered for~~

dsp.zone.THE_SHRINE_OF_RUAVITAU
regionalItems = {11040, 10951}, -- Weaver's Torque / Terminus Earring

[dsp.zone.THE_BOYAHDA_TREE
regionalItems = {11038, 10948}, -- Carver's Torque / Dragonkin Earring

edit: was fixed by OP

Ivaar · 2019-12-08T02:16:35Z

For range hints on chest examine the high/low number is random number between 5-20 added/subtracted to the correct answer.

If the high/low number is greater than 98 or less than 11 the message changes to less/greater than

Credit goes to byrth for those findings, you can find detailed info in the boxdestroyer addon for windower or my ashita port of boxdestroyer
Thief's tools range is 8-32, living key is 6-24 and skeleton key is 4-16

Omnione · 2019-12-08T12:24:19Z

You know this is one thing I was sad about, I’m not sure if I can get this to be compatible with box destroyer, I might have to do some research into what packet gets returned so I can get it pushed so box destroyer can pick it up

TeoTwawki · 2019-12-08T18:46:49Z

You know this is one thing I was sad about, I’m not sure if I can get this to be compatible with box destroyer, I might have to do some research into what packet gets returned so I can get it pushed so box destroyer can pick it up

I think should just be the event packets (and messages?) that reach the client.

Ivaar · 2019-12-08T22:31:39Z

You know this is one thing I was sad about, I’m not sure if I can get this to be compatible with box destroyer, I might have to do some research into what packet gets returned so I can get it pushed so box destroyer can pick it up

that think should just be the event packets (and messages?) that reach the client.

messageSpecial for 0x2A, what isn't compatible?

Omnione · 2019-12-08T22:32:50Z

not sure yet, i need to do some testing, ill let update if i find anything, it might be that dsp send the packet different

Omnione · 2019-12-08T22:33:20Z

or i need to add some params

Omnione · 2019-12-08T22:47:18Z

Oh wait is boxdestroyer dead now and we need to use lockpick?

Ivaar · 2019-12-08T22:49:09Z

Lockpick is windower 5. Boxdestroyer should be working, are you on windower or ashita?

Omnione · 2019-12-08T22:49:26Z

windower

Ivaar · 2019-12-08T22:51:16Z

Make sure you are using the one in the launcher? What specifically isn't working?

Omnione · 2019-12-08T22:52:19Z

im not getting any feedback at all from it on dsp, nothing at all

Omnione · 2019-12-08T22:56:55Z

im gonna try ashita see what i can get from that

Ivaar · 2019-12-08T22:59:54Z

Likely due to DPS using player id in the menu event instead of the npc id.

Omnione · 2019-12-08T23:00:45Z

Ah thats probly what it is

Omnione · 2019-12-09T23:37:37Z

I'm going to work on adding the extra hints from different keys next, once this is ok

Omnione · 2019-12-09T23:44:12Z

Only discrepancy, if you can call it that, is that the commented item names are misordered for

dsp.zone.THE_SHRINE_OF_RUAVITAU
regionalItems = {11040, 10951}, -- Weaver's Torque / Terminus Earring

[dsp.zone.THE_BOYAHDA_TREE
regionalItems = {11038, 10948}, -- Carver's Torque / Dragonkin Earring

Oh i fixed this too btw

stale

Omnione · 2019-12-10T18:17:21Z

took a bath

Omnione · 2019-12-10T21:48:18Z

Id like to make a note for this not to get merged until the problems of claiming with pets is resoloved please, as it will break as it currently is, as pet abilities do not claim pysical and magical.

scripts/globals/items/bottle_of_ascetics_tonic.lua

scripts/globals/items/pinch_of_mana_powder.lua

scripts/globals/effects/pax.lua

m241dan · 2020-01-13T16:01:59Z

Casket Prowess from Regime needs to be divided by 100. It is not in percentage form and it is causing 100% casket rate with casket prowess.

TeoTwawki · 2020-01-13T16:43:13Z

Casket Prowess from Regime needs to be divided by 100. It is not in percentage form and it is causing 100% casket rate with casket prowess.

I don't see it being touched in the PR and in master branch PROWESS_CASKET_RATE is still unimplemented.

m241dan · 2020-01-13T16:44:19Z

The effect isn't it. But he grabs the power straight off the effect, which is scripted in regimes.

So, there is no mod, no, but the effect still has power.

TeoTwawki · 2020-01-14T05:07:53Z

Prowess is multiple effects:

    -- *Prowess increases not currently retail accurate.
    -- GoV Prowess bonus effects, real effect at ID 474
    PROWESS_CASKET_RATE      = 777, -- (Unimplemented)
    PROWESS_SKILL_RATE       = 778, -- (Unimplemented)
    PROWESS_CRYSTAL_YEILD    = 779, -- (Unimplemented)
    PROWESS_TH               = 780, -- +1 per tier
    PROWESS_ATTACK_SPEED     = 781, -- *flat 4% for now
    PROWESS_HP_MP            = 782, -- Base 3% and another 1% per tier.
    PROWESS_ACC_RACC         = 783, -- *flat 4% for now
    PROWESS_ATT_RATT         = 784, -- *flat 4% for now
    PROWESS_MACC_MATK        = 785, -- *flat 4% for now
    PROWESS_CURE_POTENCY     = 786, -- *flat 4% for now
    PROWESS_WS_DMG           = 787, -- (Unimplemented) 2% per tier.
    PROWESS_KILLER           = 788, -- *flat +4 for now

these are effect IDs and the effect was never implemented before this pr and I did not see it earlier, but maybe I missed it.

Pretty sure real problem lies in regimes.lua not having a specific case for the right prowess and applying to big a value to the wrong damn one because of it.

And fix that rebase @Omnione

TeoTwawki · 2020-01-15T19:13:17Z

rebase required, stuff changed again

temp item scripts handled rate control and PROWESS_CASKET_RATE handling corrected

- Make notes concerning retail accuracy of Prowess buffs.

removed a left over print statement.

Omnione · 2020-01-15T23:50:16Z

Right that should all be good now, tested everything and it seems to be working well, cheers for helping Teo.

TeoTwawki · 2020-01-16T01:12:25Z

🍻

kaincenteno · 2020-01-16T19:10:41Z

Maybe we could test in oldschool? Metal should be online right now and I'll go online late in the evening with Jameson and Junioat 9:30PST

m241dan · 2020-01-21T22:46:50Z

Been using this PR on my server:

Quicksand Caves seems to be missing?
Sanctuary of ZiTah gives japanese characters on chests
I think you already got the Tahrongi issues
Yhoat "range" hints don't seem to give numbers
Also, on occassion after interacting with a chest everything becomes "too far" to interact with, and if you hit a zone line you go to an "unknown" zone.

Omnione · 2020-01-23T21:44:45Z

m241dan your right,
• seems i missed quicksand caves.
• Sanctuary of ZiTah same issue as Tahrongi.
• Yhoat range hints, not sure about that, ill have to dig a bit deeper.
• that last thing about zoning, wtf, lol i have no idea how that is happening.

Omnione · 2020-01-23T21:51:07Z

M241dan if you need to ask me anything you can hit me up on the dsp discord, i go by MrSent on there.

src/map/lua/lua_baseentity.cpp

TeoTwawki reviewed Dec 7, 2019

View reviewed changes

scripts/globals/caskets.lua Show resolved Hide resolved

TeoTwawki previously requested changes Dec 7, 2019

View reviewed changes

TeoTwawki reviewed Dec 11, 2019

View reviewed changes

scripts/globals/items/bottle_of_ascetics_tonic.lua Outdated Show resolved Hide resolved

TeoTwawki reviewed Dec 11, 2019

View reviewed changes

scripts/globals/items/pinch_of_mana_powder.lua Outdated Show resolved Hide resolved

TeoTwawki reviewed Dec 12, 2019

View reviewed changes

scripts/globals/effects/pax.lua Outdated Show resolved Hide resolved

Omnione force-pushed the Casket_PR branch from 6c82eb4 to 03a8a77 Compare January 15, 2020 21:37

All casket zones added

5dcea77

temp item scripts handled rate control and PROWESS_CASKET_RATE handling corrected

TeoTwawki force-pushed the Casket_PR branch from fac57e4 to 5e839d8 Compare January 15, 2020 22:51

- Change casket rate to a whole integer value so that 10 equals 10%

bcbf826

- Make notes concerning retail accuracy of Prowess buffs.

TeoTwawki force-pushed the Casket_PR branch from 5e839d8 to bcbf826 Compare January 15, 2020 23:07

Changed a function name to better reflect its use.

7006084

removed a left over print statement.

Added the missing Quick Sands Caves, fixed a few zone text id's

0cc9dbe

TeoTwawki reviewed Feb 3, 2020

View reviewed changes

src/map/lua/lua_baseentity.cpp Show resolved Hide resolved

Removed the use of releaseAllFromNPC when despawning a casket.

f589118

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Casket pr #6320

Casket pr #6320

Omnione commented Dec 7, 2019

TeoTwawki left a comment •

edited

Loading

wrenffxi commented Dec 7, 2019 •

edited

Loading

Ivaar commented Dec 8, 2019

Omnione commented Dec 8, 2019

TeoTwawki commented Dec 8, 2019 •

edited

Loading

Ivaar commented Dec 8, 2019

Omnione commented Dec 8, 2019

Omnione commented Dec 8, 2019

Omnione commented Dec 8, 2019

Ivaar commented Dec 8, 2019

Omnione commented Dec 8, 2019

Ivaar commented Dec 8, 2019

Omnione commented Dec 8, 2019

Omnione commented Dec 8, 2019

Ivaar commented Dec 8, 2019

Omnione commented Dec 8, 2019

Omnione commented Dec 9, 2019 •

edited

Loading

Omnione commented Dec 9, 2019

Omnione commented Dec 10, 2019

Omnione commented Dec 10, 2019 •

edited

Loading

m241dan commented Jan 13, 2020

TeoTwawki commented Jan 13, 2020

m241dan commented Jan 13, 2020 •

edited

Loading

TeoTwawki commented Jan 14, 2020 •

edited

Loading

TeoTwawki commented Jan 15, 2020

Omnione commented Jan 15, 2020

TeoTwawki commented Jan 16, 2020

kaincenteno commented Jan 16, 2020

m241dan commented Jan 21, 2020

Omnione commented Jan 23, 2020 •

edited

Loading

Omnione commented Jan 23, 2020

Casket pr #6320

Are you sure you want to change the base?

Casket pr #6320

Conversation

Omnione commented Dec 7, 2019

TeoTwawki left a comment • edited Loading

Choose a reason for hiding this comment

wrenffxi commented Dec 7, 2019 • edited Loading

Ivaar commented Dec 8, 2019

Omnione commented Dec 8, 2019

TeoTwawki commented Dec 8, 2019 • edited Loading

Ivaar commented Dec 8, 2019

Omnione commented Dec 8, 2019

Omnione commented Dec 8, 2019

Omnione commented Dec 8, 2019

Ivaar commented Dec 8, 2019

Omnione commented Dec 8, 2019

Ivaar commented Dec 8, 2019

Omnione commented Dec 8, 2019

Omnione commented Dec 8, 2019

Ivaar commented Dec 8, 2019

Omnione commented Dec 8, 2019

Omnione commented Dec 9, 2019 • edited Loading

Omnione commented Dec 9, 2019

Omnione commented Dec 10, 2019

Omnione commented Dec 10, 2019 • edited Loading

m241dan commented Jan 13, 2020

TeoTwawki commented Jan 13, 2020

m241dan commented Jan 13, 2020 • edited Loading

TeoTwawki commented Jan 14, 2020 • edited Loading

TeoTwawki commented Jan 15, 2020

Omnione commented Jan 15, 2020

TeoTwawki commented Jan 16, 2020

kaincenteno commented Jan 16, 2020

m241dan commented Jan 21, 2020

Omnione commented Jan 23, 2020 • edited Loading

Omnione commented Jan 23, 2020

TeoTwawki left a comment •

edited

Loading

wrenffxi commented Dec 7, 2019 •

edited

Loading

TeoTwawki commented Dec 8, 2019 •

edited

Loading

Omnione commented Dec 9, 2019 •

edited

Loading

Omnione commented Dec 10, 2019 •

edited

Loading

m241dan commented Jan 13, 2020 •

edited

Loading

TeoTwawki commented Jan 14, 2020 •

edited

Loading

Omnione commented Jan 23, 2020 •

edited

Loading