Merge pull request Place1#126 from DasSkelett/fix/metadata-nil-handshake

DasSkelett · Mar 6, 2022 · fbdd66c · fbdd66c
2 parents e7c2151 + cb90ac1
commit fbdd66c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/internal/devices/devices.go b/internal/devices/devices.go
@@ -280,8 +280,5 @@ func deviceListContains(devices []*storage.Device, publicKey string) bool {
 }
 
 func IsConnected(lastHandshake time.Time) bool {
-	// if lastHandshake == nil {
-	// 	return false
-	// }
 	return lastHandshake.After(time.Now().Add(-3 * time.Minute))
 }
diff --git a/internal/devices/metadata.go b/internal/devices/metadata.go
@@ -30,7 +30,7 @@ func syncMetrics(d *DeviceManager) {
 		// they may actually be connected to another replica.
 		if peer.Endpoint != nil {
 			if device, err := d.GetByPublicKey(peer.PublicKey.String()); err == nil {
-				if !IsConnected(peer.LastHandshakeTime) && !IsConnected(*device.LastHandshakeTime) {
+				if !IsConnected(peer.LastHandshakeTime) && device.LastHandshakeTime != nil && !IsConnected(*device.LastHandshakeTime) {
 					// Not connected, and we haven't been the last time either, nothing to update
 					continue
 				}