Fix: receiver hang indefinitely #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvkhoi112358
changed the title
nvkhoi112358
force-pushed
the
fix_sender
branch
from
7fa8bf2 to
490cbe9
Compare
After writing the first bytes from buffer, it doesn't "notify" the reader and continue to write to the buffer without knowing buffer is consume entirely or not. The reader hence can send wrong data to receiver. With incorrect box size, it can hang forever. `testpic` segment size is small (<65536), so it is not affected.
nvkhoi112358
force-pushed
the
fix_sender
branch
from
490cbe9 to
1deb396
Compare
|
@nvkhoi112358 and @NhanNguyen700. Thanks for the fix! Good that you use the code for higher bitrate content, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After writing the first bytes from buffer, it doesn't "notify" the reader
and continue to write to the buffer without knowing buffer is consumed entirely or not.
The reader hence can send wrong data to receiver. With incorrect box size, it can hang forever.
testpicsegment size is small (<65536), so it is not affected.Big thanks to @NhanNguyen700 for the fix.