Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Msi ms7d25/rel v1.1.3 #686

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Msi ms7d25/rel v1.1.3 #686

merged 7 commits into from
Jan 22, 2024

Conversation

miczyg1
Copy link
Contributor

@miczyg1 miczyg1 commented Oct 26, 2023

No description provided.

@miczyg1 miczyg1 force-pushed the msi_ms7d25/rel_v1.1.3 branch from 2229d3e to 6b2d55b Compare January 3, 2024 10:52
@BeataZdunczyk
Copy link
Member

@miczyg1 also add a link to the new test results spreadsheet that we have since this release: https://docs.google.com/spreadsheets/d/1wSE6xA3K3nXewwLn5lV39_2wZL1kg5AkGb4mvmG3bwE/edit?usp=sharing

@macpijan
Copy link
Contributor

macpijan commented Jan 17, 2024 •
edited
Loading

@BeataZdunczyk

also add a link to the new test results spreadsheet that we have since this release: https://docs.google.com/spreadsheets/d/1wSE6xA3K3nXewwLn5lV39_2wZL1kg5AkGb4mvmG3bwE/edit?usp=sharing

Let's use a link that directly leads to results for given platform, front page is not that interesting for subscribers.

@miczyg1 miczyg1 force-pushed the msi_ms7d25/rel_v1.1.3 branch 2 times, most recently from 84c0643 to f91807b Compare January 17, 2024 13:05
@miczyg1
Copy link
Contributor Author

miczyg1 commented Jan 17, 2024

@BeataZdunczyk

also add a link to the new test results spreadsheet that we have since this release: https://docs.google.com/spreadsheets/d/1wSE6xA3K3nXewwLn5lV39_2wZL1kg5AkGb4mvmG3bwE/edit?usp=sharing

Let's use a link that directly leads to results for given platform, front page is not that interesting for subscribers.

f91807b#diff-02c1965ab265070941dfe35aabf982d0946a2ee1545fac0763eda95ccf36162fR17

@miczyg1 miczyg1 force-pushed the msi_ms7d25/rel_v1.1.3 branch from f91807b to cfd1f2e Compare January 17, 2024 13:27
BeataZdunczyk
BeataZdunczyk requested changes Jan 22, 2024
View reviewed changes
docs/variants/msi_z690/releases.md Outdated Show resolved Hide resolved
docs/variants/msi_z690/releases.md Show resolved Hide resolved
@miczyg1 miczyg1 force-pushed the msi_ms7d25/rel_v1.1.3 branch from 190f0b1 to 1dde7fc Compare January 22, 2024 12:04
@BeataZdunczyk
Copy link
Member

@miczyg1 you can merge this release notes after fixing link checker errors https://github.com/Dasharo/docs/actions/runs/7610834739/job/20725011619?pr=686

@macpijan
Copy link
Contributor

macpijan commented Jan 22, 2024 •
edited
Loading

Shop links are broken, the same is on master, so this MR is in no way worse. We need to find out internally what has happened and fix it in a followup.

@miczyg1
Copy link
Contributor Author

miczyg1 commented Jan 22, 2024

@BeataZdunczyk the link checker fails because items have been removed from our shop. I cannot even fix this, because these items are no longer there (namely the Z690-A board and full-build PCs).

@macpijan macpijan merged commit a4d08cf into master Jan 22, 2024
3 of 4 checks passed
@macpijan macpijan deleted the msi_ms7d25/rel_v1.1.3 branch January 22, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macpijan macpijan macpijan left review comments

@BeataZdunczyk BeataZdunczyk BeataZdunczyk requested changes

@mkopec mkopec mkopec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miczyg1 @BeataZdunczyk @macpijan @mkopec