Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Optiplex documentation #968

Merged
merged 8 commits into from
Jan 3, 2025

Conversation

nedpfeiffer
Copy link
Contributor

Walking through the recovery process I noticed some issues with the Optiplex documentation, namely:

  • The Optiplex branch has been merged with Dasharo and coreboot upstream, so no need to mention it in building-manual.md
  • uefi-firmware-parser only works with version 1.9 for whatever reason. I'll include logs of the errors I encountered below if it's helpful.
  • There was a typo in the file path for the EC firmware which made it annoying to copy and paste

Here's that error I encountered with the latest version of uefi-firmware (1.11):

  Dell PFSSection: 7439ed9e-70d3-4b65-9e33-1963a7ad3c37 spec 0x01 ts 0x00 type 0x00 version .8.1.72.3002 size 0x77b148 (7844168 bytes)
    ME Container type= 0x10 version= 0x20 size= 0x30 (48 bytes) entires= 23 flags= 0xfffffc01
Traceback (most recent call last):
  File "/home/user/Downloads/venv/bin/uefi-firmware-parser", line 196, in <module>
    _process_show_extract(firmware)
  File "/home/user/Downloads/venv/bin/uefi-firmware-parser", line 19, in _process_show_extract
    parsed_object.showinfo('')
  File "/home/user/Downloads/venv/lib/python3.11/site-packages/uefi_firmware/__init__.py", line 130, in showinfo
    self.objs[i].showinfo(ts, i)
  File "/home/user/Downloads/venv/lib/python3.11/site-packages/uefi_firmware/pfs.py", line 422, in showinfo
    section.showinfo("%s  " % ts)
  File "/home/user/Downloads/venv/lib/python3.11/site-packages/uefi_firmware/pfs.py", line 324, in showinfo
    sub_object.showinfo("%s  " % ts)
  File "/home/user/Downloads/venv/lib/python3.11/site-packages/uefi_firmware/base.py", line 198, in showinfo
    self.object.showinfo(ts)
  File "/home/user/Downloads/venv/lib/python3.11/site-packages/uefi_firmware/me.py", line 675, in showinfo
    partition.showinfo("  %s" % ts)
  File "/home/user/Downloads/venv/lib/python3.11/site-packages/uefi_firmware/me.py", line 625, in showinfo
    purple(self.structure.Name.decode("utf-8")), purple(self.structure.Owner),
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe0 in position 0: invalid continuation byte

Hope this is helpful, thanks!

@nedpfeiffer
Copy link
Contributor Author

nedpfeiffer commented Dec 29, 2024

Two things:

  • An error is being thrown by pre-commit.ci due to line lengths being too long, but these long lines are necessary because the extracted firmware file paths are deeply nested.
  • After running uefi-firmware-parser I'm not able to find the BIOS ACM file listed in the documentation, although I can find the EC firmware just fine. Has the BIOS ACM file path changed since these docs were last updated? See below:
ned@fedora:~/Downloads/_O7010A29.exe.extracted/65C10_output/pfsobject/section-7ec6c2b0-3fe3-42a0-a316-22dd0517c1e8/volume-0x50000$ ls | grep file-d38
file-d386beb8-4b54-4e69-94f5-06091f67e0d3
ned@fedora:~/Downloads/_O7010A29.exe.extracted/65C10_output/pfsobject/section-7ec6c2b0-3fe3-42a0-a316-22dd0517c1e8/volume-0x50000$ ls | grep file-2d2
ned@fedora:~/Downloads/_O7010A29.exe.extracted/65C10_output/pfsobject/section-7ec6c2b0-3fe3-42a0-a316-22dd0517c1e8/volume-0x50000$ cd
ned@fedora:~$ # EC firmware is there, but what's the path for the BIOS ACM file?

Thanks!

@pietrushnic
Copy link
Contributor

@nedpfeiffer, thank you for your contribution. Would you mind fixing pre-commit issues?

@nedpfeiffer
Copy link
Contributor Author

nedpfeiffer commented Jan 2, 2025

@pietrushnic I've fixed the issues with the line lengths and trailing white space

Copy link
Member

@filipleple filipleple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miczyg1 miczyg1 merged commit 6015533 into Dasharo:master Jan 3, 2025
4 checks passed
@nedpfeiffer
Copy link
Contributor Author

To clarify, what is the correct path for the BIOS ACM file? The file path in the documentation doesn't exist:

ned@fedora:~/Downloads/_O7010A29.exe.extracted/65C10_output/pfsobject/section-7ec6c2b0-3fe3-42a0-a316-22dd0517c1e8/volume-0x50000$ ls | grep file-d38
file-d386beb8-4b54-4e69-94f5-06091f67e0d3
ned@fedora:~/Downloads/_O7010A29.exe.extracted/65C10_output/pfsobject/section-7ec6c2b0-3fe3-42a0-a316-22dd0517c1e8/volume-0x50000$ ls | grep file-2d2
ned@fedora:~/Downloads/_O7010A29.exe.extracted/65C10_output/pfsobject/section-7ec6c2b0-3fe3-42a0-a316-22dd0517c1e8/volume-0x50000$ cd
ned@fedora:~$ # EC firmware is there, but what's the path for the BIOS ACM file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants