-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Optiplex documentation #968
Conversation
Two things:
Thanks! |
@nedpfeiffer, thank you for your contribution. Would you mind fixing pre-commit issues? |
@pietrushnic I've fixed the issues with the line lengths and trailing white space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To clarify, what is the correct path for the BIOS ACM file? The file path in the documentation doesn't exist:
|
Walking through the recovery process I noticed some issues with the Optiplex documentation, namely:
building-manual.md
uefi-firmware-parser
only works with version1.9
for whatever reason. I'll include logs of the errors I encountered below if it's helpful.Here's that error I encountered with the latest version of
uefi-firmware
(1.11
):Hope this is helpful, thanks!