Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform foreign key checks even if empty tables exist ... #190

Closed
wants to merge 1 commit into from
Closed

Perform foreign key checks even if empty tables exist ... #190

wants to merge 1 commit into from

Conversation

nickzoic
Copy link
Contributor

  • Tables with 0 rows are still valid tables ... mark table valid on seeing header or data row.

  • This was preventing foreign key checks from running if any table was empty because of the
    unless @validated_tables.has_value?(false) in TableGroup.validate_foreign_keys

@coveralls
Copy link

coveralls commented Nov 16, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 97.064% when pulling 756d0fd on nickzoic:bugfix/foreign-key-checks into 7780c78 on theodi:master.

@nickzoic nickzoic mentioned this pull request Dec 9, 2016
Open
@nickzoic
Copy link
Contributor Author

nickzoic commented Dec 9, 2016

This is now part of PR #193 so I'm closing this one ...

@nickzoic nickzoic closed this Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickzoic @coveralls