Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added analytics report generator (#2641) #2694

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

jpaten
Copy link
Contributor

@jpaten jpaten commented Jan 23, 2025

  • Added analytics notebook calling outbound links functions, currently set to generate a notebook for December 2024.
  • See sheet here for example putput

@jpaten jpaten requested review from NoopDog and hunterckx January 23, 2025 01:57
@jpaten jpaten linked an issue Jan 23, 2025 that may be closed by this pull request
@github-actions github-actions bot added the canary Done by the Clever Canary label Jan 23, 2025
Copy link
Contributor

@hunterckx hunterckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nitpicks: anvil_portal_params in the notebook should be renamed to reference HCA rather than AnVIL, and while you're at it there's a typo in the spelling of "exclude" that you might as well also fix on line 15 of constants.py

Overall looks good!

@jpaten
Copy link
Contributor Author

jpaten commented Jan 26, 2025

Thanks for those notes @hunterckx! This should be ready for re-review now, the updated sheet is here

@jpaten jpaten requested a review from hunterckx January 26, 2025 23:11
@hunterckx hunterckx merged commit 8ab8440 into main Jan 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outbound links report for HCA Data Portal
2 participants