Removed active and needsApproval properties from Dataset interface; U…

…pdated URL in readme to replace comma with a period
DataBiosphere · Sep 4, 2024 · 034e358 · 034e358
1 parent c136a0d
commit 034e358
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 7 deletions.
diff --git a/DEVNOTES.md b/DEVNOTES.md
@@ -78,7 +78,7 @@ run in GitHub Actions. Create a `cypress.env.json` file in the root of your
 local repo that looks like this:
 ```json
 {
-  "baseUrl": "https://local.dsde-dev,broadinstitute.org:3000/"
+  "baseUrl": "https://local.dsde-dev.broadinstitute.org:3000/"
 }
 ```
 Cypress will use these values in `cypress.config.js` and `cypress/support/commands.js`

diff --git a/cypress/component/DarCollectionReview/dar_collection_review.spec.js b/cypress/component/DarCollectionReview/dar_collection_review.spec.js
@@ -464,9 +464,7 @@ const dar = {
       'createUserId': null,
       'updateDate': 1643730658770,
       'updateUserId': 11111,
-      'active': true,
       'consentName': null,
-      'needsApproval': null,
       'alias': 999,
       'datasetIdentifier': 'DUOS-00999',
       'dataUse': {
@@ -670,8 +668,6 @@ const dacDatasets = [{
       'propertyValue': 'Sleep Apnea'
     }
   ],
-  'active': true,
-  'needsApproval': true,
   'isAssociatedToDataOwners': null,
   'updateAssociationToDataOwnerAllowed': null,
   'alias': 999,

diff --git a/src/types/model.ts b/src/types/model.ts
@@ -104,8 +104,6 @@ export interface Dataset {
   deletable: boolean;
   properties: DatasetProperty[];
   study: Study;
-  active: boolean;
-  needsApproval: boolean;
   alias: string;
   datasetIdentifier: string;
   objectId: string;